Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base image name in node-feature-discovery.yaml #80

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Conversation

carlmes
Copy link
Member

@carlmes carlmes commented Nov 22, 2024

Fixed for OpenShift 4.17

@carlmes carlmes requested a review from a team as a code owner November 22, 2024 21:37
@carlmes
Copy link
Member Author

carlmes commented Nov 22, 2024

Tested working on OpenShift 4.17 cluster:

image

No more crashed pods in the openshift-nfd namespace:

image

All labels showing on GPU Enabled Node:

image

@carlmes
Copy link
Member Author

carlmes commented Nov 22, 2024

Tested working on OpenShift 4.15 cluster:

image

All pods start ok. We noticed that the controller manager pod was using the new -rhel9 image, however the other pods were not, but behaving correctly. This might be auto decided by the subscription rather than the update to the subscription:

image

carlmes added a commit to carlmes/gitops-catalog that referenced this pull request Nov 22, 2024
GitOps projects that use the nfd operator have been failing in OpenShift 4.17, it looks like the base image has been changed - we verified this by manually installing the operator and observing the new image name.

Update base image in node-feature-discovery.yaml fixes the issue.

We've tested this on an OpenShift 4.17 and 4.15 cluster, and NFD is now working great. More details in one of the downstream projects at: redhat-ai-services/ai-accelerator#80
@carlmes
Copy link
Member Author

carlmes commented Nov 22, 2024

Cross referencing the same update to the upstream GitOps CoP project: redhat-cop/gitops-catalog#341

@strangiato strangiato merged commit 752ebbc into main Nov 23, 2024
5 checks passed
@strangiato strangiato deleted the nfd-fix branch November 23, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants