-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow pipeline service SREs to view openshift-pipelines webhook configuration #4409
allow pipeline service SREs to view openshift-pipelines webhook configuration #4409
Conversation
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test appstudio-e2e-tests |
In case it wasn't clear the prior e2e-test job failed due to a timeout deploying the pipeline gitops app |
sorry didn't look @Dannyb48 ... ok I'll bring up a cluster, bootstrap locally with this branch, and see where my typo's etc. are |
@gabemontero no worries! I didn't expect the output that I was expecting from CI and I saw that openshift-ci killed the job after two hours. So I wanted to bubble it up to make sure that you weren't scratching your head. |
cool deal @Dannyb48 .... and I just realized if it is not a typo, I just realized it could be a gitops sync wave thing, where it tries this before the openshift pipelines operator creates the if it is, I think adding a simple namespace create before the role creations should do the trick |
493d016
to
f143d01
Compare
well that did not work with kustomize build:
|
812383b
to
4e6ee89
Compare
cluster resource contraints on the e2e-tests failure /test appstudio-e2e-tests |
/test appstudio-e2e-tests |
4e6ee89
to
b37c072
Compare
New changes are detected. LGTM label has been removed. |
…guration rh-pre-commit.version: 2.3.1 rh-pre-commit.check-secrets: ENABLED
98551e7
to
80a1882
Compare
@gabemontero: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
a9abca1
into
redhat-appstudio:main
once we bump the nightly version on konflux, someone should update the
TektonConfig
to make the webhooks non-blocking, since SRVKP-4442 will be availableThis change will allow you all the view the webhook config on the konflux clusters and confirm the
TektonConfig
changes have taken hold.@enarha @savitaashture @jkhelil FYI
rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED