Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow pipeline service SREs to view openshift-pipelines webhook configuration #4409

Conversation

gabemontero
Copy link
Contributor

@gabemontero gabemontero commented Aug 28, 2024

once we bump the nightly version on konflux, someone should update the TektonConfig to make the webhooks non-blocking, since SRVKP-4442 will be available

This change will allow you all the view the webhook config on the konflux clusters and confirm the TektonConfig changes have taken hold.

@enarha @savitaashture @jkhelil FYI

rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED

@gabemontero gabemontero requested a review from enarha August 28, 2024 12:49
@openshift-ci openshift-ci bot requested a review from xinredhat August 28, 2024 12:49
Copy link

openshift-ci bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gabemontero
Copy link
Contributor Author

/test appstudio-e2e-tests

@gabemontero
Copy link
Contributor Author

In case it wasn't clear the prior e2e-test job failed due to a timeout deploying the pipeline gitops app

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/redhat-appstudio_infra-deployments/4409/pull-ci-redhat-appstudio-infra-deployments-main-appstudio-e2e-tests/1828776999603146752/artifacts/appstudio-e2e-tests/redhat-appstudio-e2e/build-log.txt

sorry didn't look @Dannyb48 ... ok I'll bring up a cluster, bootstrap locally with this branch, and see where my typo's etc. are

@Dannyb48
Copy link

@gabemontero no worries! I didn't expect the output that I was expecting from CI and I saw that openshift-ci killed the job after two hours. So I wanted to bubble it up to make sure that you weren't scratching your head.

@gabemontero
Copy link
Contributor Author

In case it wasn't clear the prior e2e-test job failed due to a timeout deploying the pipeline gitops app
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/redhat-appstudio_infra-deployments/4409/pull-ci-redhat-appstudio-infra-deployments-main-appstudio-e2e-tests/1828776999603146752/artifacts/appstudio-e2e-tests/redhat-appstudio-e2e/build-log.txt

sorry didn't look @Dannyb48 ... ok I'll bring up a cluster, bootstrap locally with this branch, and see where my typo's etc. are

cool deal @Dannyb48 .... and I just realized if it is not a typo, I just realized it could be a gitops sync wave thing, where it tries this before the openshift pipelines operator creates the openshift-pipelines namespace ...

if it is, I think adding a simple namespace create before the role creations should do the trick

@gabemontero gabemontero force-pushed the add-pipeline-webhook-cfg-sre-role branch from 493d016 to f143d01 Compare August 28, 2024 17:22
@gabemontero
Copy link
Contributor Author

well that did not work with kustomize build:

Error when running kustomize build for components/pipeline-service/staging/stone-stage-p01/resources: Error: accumulating resources: accumulation err='accumulating resources from '../../base': '/home/runner/work/infra-deployments/infra-deployments/components/pipeline-service/staging/base' must resolve to a file': recursed accumulation of path '/home/runner/work/infra-deployments/infra-deployments/components/pipeline-service/staging/base': accumulating resources: accumulation err='accumulating resources from '../../base/rbac': '/home/runner/work/infra-deployments/infra-deployments/components/pipeline-service/base/rbac' must resolve to a file': recursed merging from path '/home/runner/work/infra-deployments/infra-deployments/components/pipeline-service/base/rbac': may not add resource with an already registered id: Namespace.v1.[noGrp]/openshift-pipelines.[noNs]

@gabemontero gabemontero force-pushed the add-pipeline-webhook-cfg-sre-role branch 2 times, most recently from 812383b to 4e6ee89 Compare August 28, 2024 18:46
@gabemontero
Copy link
Contributor Author

cluster resource contraints on the e2e-tests failure

/test appstudio-e2e-tests

@gabemontero gabemontero removed the request for review from xinredhat August 28, 2024 20:31
@gabemontero
Copy link
Contributor Author

/test appstudio-e2e-tests

@gabemontero gabemontero force-pushed the add-pipeline-webhook-cfg-sre-role branch from 4e6ee89 to b37c072 Compare August 29, 2024 13:02
@openshift-ci openshift-ci bot removed the lgtm label Aug 29, 2024
Copy link

openshift-ci bot commented Aug 29, 2024

New changes are detected. LGTM label has been removed.

…guration

rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
@gabemontero gabemontero force-pushed the add-pipeline-webhook-cfg-sre-role branch from 98551e7 to 80a1882 Compare August 29, 2024 14:16
Copy link

openshift-ci bot commented Aug 29, 2024

@gabemontero: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-hac-e2e-tests 80a1882 link false /test appstudio-hac-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a9abca1 into redhat-appstudio:main Aug 29, 2024
6 of 7 checks passed
@gabemontero gabemontero deleted the add-pipeline-webhook-cfg-sre-role branch August 29, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants