Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image value for opentelemetry image #4426

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Fix image value for opentelemetry image #4426

merged 1 commit into from
Aug 30, 2024

Conversation

raks-tt
Copy link
Contributor

@raks-tt raks-tt commented Aug 29, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from hugares and psturc August 29, 2024 19:32
@raks-tt
Copy link
Contributor Author

raks-tt commented Aug 29, 2024

@mftb and @mike-kingsbury

@mftb
Copy link
Contributor

mftb commented Aug 29, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Aug 29, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 29, 2024 •
edited
Loading

@raks-tt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-hac-e2e-tests 4b88daa link false /test appstudio-hac-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mike-kingsbury
Copy link
Contributor

/lgtm

@raks-tt raks-tt force-pushed the update_otel_image branch from 4b88daa to 7e64f78 Compare August 30, 2024 15:37
@openshift-ci openshift-ci bot removed the lgtm label Aug 30, 2024
@mftb
Copy link
Contributor

mftb commented Aug 30, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Aug 30, 2024
@raks-tt raks-tt force-pushed the update_otel_image branch from 7e64f78 to 17c2b83 Compare August 30, 2024 16:13
@openshift-ci openshift-ci bot removed the lgtm label Aug 30, 2024
hugares
hugares approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 30, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hugares, mftb, raks-tt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1a25ff5 into redhat-appstudio:main Aug 30, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugares hugares hugares approved these changes

@psturc psturc Awaiting requested review from psturc

Assignees

@mftb mftb

@hugares hugares

@mike-kingsbury mike-kingsbury

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raks-tt @mftb @mike-kingsbury @hugares