Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KONFLUX-5297): Expose metrics for Tekton Resolver leases distribution alerts #4875

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jhutar
Copy link
Member

@jhutar jhutar commented Nov 11, 2024

No description provided.

@jhutar jhutar force-pushed the fix49-tekton-resolver-leases branch from 2c590be to dfc3564 Compare November 11, 2024 15:17
@jhutar jhutar changed the title feat(KONFLUX-5297): Expose metrics for Pipelines leases distribution alerts feat(KONFLUX-5297): Expose metrics for Tekton Resolver leases distribution alerts Nov 11, 2024
Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hugares, jhutar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhutar
Copy link
Member Author

jhutar commented Nov 13, 2024

/retest

@hugares
Copy link
Contributor

hugares commented Nov 13, 2024

@jhutar there was a problematic change at some point causing the e2e to fail, can you rebase this PR, failure might be caused by that problem which is fixed on latest main

@jhutar jhutar force-pushed the fix49-tekton-resolver-leases branch from dfc3564 to a5d7121 Compare November 14, 2024 17:04
@openshift-ci openshift-ci bot removed the lgtm label Nov 14, 2024
Copy link

openshift-ci bot commented Nov 14, 2024

New changes are detected. LGTM label has been removed.

@jhutar
Copy link
Member Author

jhutar commented Nov 15, 2024

Cool, it helped, thank you @hugares !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants