Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install knative-eventing instead knative-eventing-core #4974

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maruiz93
Copy link

  • KubeArchive needs knative-eventing instead knative-eventing-core now that brokers are introduced
  • KubeArchive is using in-memory brokers by default which we think is enough. If you think Konflux need more performant brokers like Kafka those should be included.

Signed-off-by: Marta Anon <manon@redhat.com>
Copy link

openshift-ci bot commented Nov 25, 2024

Hi @maruiz93. Thanks for your PR.

I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rh-hemartin
Copy link
Contributor

/ok-to-test

@rh-hemartin
Copy link
Contributor

/approve

@rh-hemartin
Copy link
Contributor

/test appstudio-e2e-tests

@rh-hemartin
Copy link
Contributor

/approve

@skoved
Copy link
Contributor

skoved commented Dec 17, 2024

/approve

@skoved
Copy link
Contributor

skoved commented Dec 17, 2024

/lgtm

@rh-hemartin
Copy link
Contributor

/retest

Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hugares, maruiz93, rh-hemartin, skoved

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hugares hugares removed the lgtm label Dec 17, 2024
@hugares
Copy link
Contributor

hugares commented Dec 17, 2024

The new manifest being brought are not passing kubelinter checks:

kustomize build components/knative-eventing/base/ | kube-linter lint -
KubeLinter v0.6.4-0-g4f0b1e01fd

<standard input>: (object: knative-eventing/imc-controller apps/v1, Kind=Deployment) container "controller" has cpu request 0 (check: unset-cpu-requirements, remediation: Set CPU requests and limits for your container based on its requirements. Refer to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#requests-and-limits for details.)

<standard input>: (object: knative-eventing/imc-controller apps/v1, Kind=Deployment) container "controller" has cpu limit 0 (check: unset-cpu-requirements, remediation: Set CPU requests and limits for your container based on its requirements. Refer to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#requests-and-limits for details.)

<standard input>: (object: knative-eventing/imc-controller apps/v1, Kind=Deployment) container "controller" has memory request 0 (check: unset-memory-requirements, remediation: Set memory requests and limits for your container based on its requirements. Refer to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#requests-and-limits for details.)

<standard input>: (object: knative-eventing/imc-controller apps/v1, Kind=Deployment) container "controller" has memory limit 0 (check: unset-memory-requirements, remediation: Set memory requests and limits for your container based on its requirements. Refer to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#requests-and-limits for details.)

<standard input>: (object: knative-eventing/imc-dispatcher apps/v1, Kind=Deployment) container "dispatcher" has cpu request 0 (check: unset-cpu-requirements, remediation: Set CPU requests and limits for your container based on its requirements. Refer to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#requests-and-limits for details.)

<standard input>: (object: knative-eventing/imc-dispatcher apps/v1, Kind=Deployment) container "dispatcher" has cpu limit 0 (check: unset-cpu-requirements, remediation: Set CPU requests and limits for your container based on its requirements. Refer to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#requests-and-limits for details.)

<standard input>: (object: knative-eventing/imc-dispatcher apps/v1, Kind=Deployment) container "dispatcher" has memory request 0 (check: unset-memory-requirements, remediation: Set memory requests and limits for your container based on its requirements. Refer to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#requests-and-limits for details.)

<standard input>: (object: knative-eventing/imc-dispatcher apps/v1, Kind=Deployment) container "dispatcher" has memory limit 0 (check: unset-memory-requirements, remediation: Set memory requests and limits for your container based on its requirements. Refer to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#requests-and-limits for details.)

<standard input>: (object: knative-eventing/mt-broker-controller apps/v1, Kind=Deployment) container "mt-broker-controller" has cpu limit 0 (check: unset-cpu-requirements, remediation: Set CPU requests and limits for your container based on its requirements. Refer to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#requests-and-limits for details.)

<standard input>: (object: knative-eventing/mt-broker-controller apps/v1, Kind=Deployment) container "mt-broker-controller" has memory limit 0 (check: unset-memory-requirements, remediation: Set memory requests and limits for your container based on its requirements. Refer to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#requests-and-limits for details.)

<standard input>: (object: knative-eventing/mt-broker-filter apps/v1, Kind=Deployment) container "filter" has cpu limit 0 (check: unset-cpu-requirements, remediation: Set CPU requests and limits for your container based on its requirements. Refer to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#requests-and-limits for details.)

<standard input>: (object: knative-eventing/mt-broker-filter apps/v1, Kind=Deployment) container "filter" has memory limit 0 (check: unset-memory-requirements, remediation: Set memory requests and limits for your container based on its requirements. Refer to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#requests-and-limits for details.)

<standard input>: (object: knative-eventing/mt-broker-ingress apps/v1, Kind=Deployment) container "ingress" has cpu limit 0 (check: unset-cpu-requirements, remediation: Set CPU requests and limits for your container based on its requirements. Refer to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#requests-and-limits for details.)

<standard input>: (object: knative-eventing/mt-broker-ingress apps/v1, Kind=Deployment) container "ingress" has memory limit 0 (check: unset-memory-requirements, remediation: Set memory requests and limits for your container based on its requirements. Refer to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#requests-and-limits for details.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants