Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new ARM flavor with larger disk #5050

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

hugares
Copy link
Contributor

@hugares hugares commented Dec 4, 2024

Change back all ARM flavors to default disk size and create a new flavor, same as default one with larger disk. Create a new one to not increase default thus increasing running cost for all builds that do not need more space.

KFLUXINFRA-1141

@hugares hugares requested a review from arewm December 4, 2024 18:16
@openshift-ci openshift-ci bot requested a review from mshaposhnik December 4, 2024 18:16
@openshift-ci openshift-ci bot added the approved label Dec 4, 2024
@arewm
Copy link
Contributor

arewm commented Dec 4, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 4, 2024
Copy link
Contributor

@arewm arewm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add the platform to line 14

dynamic-platforms: "\

@arewm arewm removed the lgtm label Dec 4, 2024
@hugares
Copy link
Contributor Author

hugares commented Dec 4, 2024

I think we need to add the platform to line 14

dynamic-platforms: "\

Good point, I know this but somehow forgot..

Change back all ARM flavors to default disk size and create a new
flavor, same as default one with larger disk. Create a new one to not
increase default thus increasing running cost for all builds that do not
need more space.

KFLUXINFRA-1141

Signed-off-by: Hugo Ares <hares@redhat.com>
@hugares
Copy link
Contributor Author

hugares commented Dec 4, 2024

I think we need to add the platform to line 14

dynamic-platforms: "\

Good point, I know this but somehow forgot..

Done

Copy link
Contributor

@arewm arewm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 4, 2024
Copy link

openshift-ci bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arewm, hugares

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hugares
Copy link
Contributor Author

hugares commented Dec 4, 2024

As usual, merging this change as e2e are not covering the files change in this PR

@hugares hugares merged commit dd68d82 into redhat-appstudio:main Dec 4, 2024
3 of 6 checks passed
@hugares hugares deleted the hares-art-disk-v2 branch December 4, 2024 18:34
mike-kingsbury pushed a commit to mike-kingsbury/infra-deployments that referenced this pull request Dec 6, 2024
Change back all ARM flavors to default disk size and create a new
flavor, same as default one with larger disk. Create a new one to not
increase default thus increasing running cost for all builds that do not
need more space.

KFLUXINFRA-1141

Signed-off-by: Hugo Ares <hares@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants