Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename tnf to certSuite #128

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Rename tnf to certSuite #128

merged 2 commits into from
Aug 29, 2024

Conversation

bnshr
Copy link
Contributor

@bnshr bnshr commented Aug 29, 2024 •
edited
Loading

@bnshr bnshr mentioned this pull request Aug 29, 2024
Merged
@bnshr bnshr force-pushed the renaming-tool branch 5 times, most recently from 4e7f1d2 to defe889 Compare August 29, 2024 13:04
sebrandon1
sebrandon1 reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@sebrandon1 sebrandon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it needs to be camelcase certSuite. I think certsuite one word should do fine to match everything else.

@bnshr
Copy link
Contributor Author

bnshr commented Aug 29, 2024

I don't think it needs to be camelcase certSuite. I think certsuite one word should do fine to match everything else.

Initially I considered that, then I saw other fields are in camelcase and so for consistency reason, changed to certSuite.

@sebrandon1 sebrandon1 merged commit 07d2518 into main Aug 29, 2024
1 check passed
@sebrandon1 sebrandon1 deleted the renaming-tool branch August 29, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebrandon1 sebrandon1 sebrandon1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnshr @sebrandon1