access-control and operator test suite updates (#953)

The non-root check test case has been renamed in: redhat-best-practices-for-k8s/certsuite#2479 Also, four operator test cases have been moved to access-control test suite. I just removed them for now as they might need more rework in follow-up PRs.
redhat-best-practices-for-k8s · Oct 15, 2024 · dec29ec · dec29ec
1 parent 6fd5d7a
commit dec29ec
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 454 deletions.
diff --git a/tests/accesscontrol/parameters/parameters.go b/tests/accesscontrol/parameters/parameters.go
@@ -58,7 +58,7 @@ const (
 	TestCaseNameAccessControlBpfCapability          = "access-control-bpf-capability-check"
 	TestCaseNameAccessControlContainerHostPort      = "access-control-container-host-port"
 	TestCaseNameAccessControlSysAdminCapability     = "access-control-sys-admin-capability-check"
-	TestCaseNameAccessControlNonRootUser            = "access-control-security-context-non-root-user-check"
+	TestCaseNameAccessControlNonRootUserID          = "access-control-security-context-non-root-user-id-check"
 	TestCaseNameAccessControlClusterRoleBindings    = "access-control-cluster-role-bindings"
 	CertsuiteNodePortTcName                         = "access-control-service-type"
 	TestCaseNameAccessControlPrivilegeEscalation    = "access-control-security-context-privilege-escalation"

diff --git a/...access_control_container_non-root_user.go → ...ess_control_container_non-root_user_id.go b/...access_control_container_non-root_user.go → ...ess_control_container_non-root_user_id.go
@@ -54,13 +54,13 @@ var _ = Describe("Access-control non-root user,", func() {
 
 		By("Start test")
 		err = globalhelper.LaunchTests(
-			tsparams.TestCaseNameAccessControlNonRootUser,
+			tsparams.TestCaseNameAccessControlNonRootUserID,
 			globalhelper.ConvertSpecNameToFileName(CurrentSpecReport().FullText()), randomReportDir, randomCertsuiteConfigDir)
 		Expect(err).ToNot(HaveOccurred())
 
 		By("Verify test case status in Claim report")
 		err = globalhelper.ValidateIfReportsAreValid(
-			tsparams.TestCaseNameAccessControlNonRootUser,
+			tsparams.TestCaseNameAccessControlNonRootUserID,
 			globalparameters.TestCasePassed, randomReportDir)
 		Expect(err).ToNot(HaveOccurred())
 	})
@@ -85,13 +85,13 @@ var _ = Describe("Access-control non-root user,", func() {
 
 		By("Start test")
 		err = globalhelper.LaunchTests(
-			tsparams.TestCaseNameAccessControlNonRootUser,
+			tsparams.TestCaseNameAccessControlNonRootUserID,
 			globalhelper.ConvertSpecNameToFileName(CurrentSpecReport().FullText()), randomReportDir, randomCertsuiteConfigDir)
 		Expect(err).ToNot(HaveOccurred())
 
 		By("Verify test case status in Claim report")
 		err = globalhelper.ValidateIfReportsAreValid(
-			tsparams.TestCaseNameAccessControlNonRootUser,
+			tsparams.TestCaseNameAccessControlNonRootUserID,
 			globalparameters.TestCaseFailed, randomReportDir)
 		Expect(err).ToNot(HaveOccurred())
 	})
@@ -126,13 +126,13 @@ var _ = Describe("Access-control non-root user,", func() {
 
 		By("Start test")
 		err = globalhelper.LaunchTests(
-			tsparams.TestCaseNameAccessControlNonRootUser,
+			tsparams.TestCaseNameAccessControlNonRootUserID,
 			globalhelper.ConvertSpecNameToFileName(CurrentSpecReport().FullText()), randomReportDir, randomCertsuiteConfigDir)
 		Expect(err).ToNot(HaveOccurred())
 
 		By("Verify test case status in Claim report")
 		err = globalhelper.ValidateIfReportsAreValid(
-			tsparams.TestCaseNameAccessControlNonRootUser,
+			tsparams.TestCaseNameAccessControlNonRootUserID,
 			globalparameters.TestCasePassed, randomReportDir)
 		Expect(err).ToNot(HaveOccurred())
 	})
@@ -170,13 +170,13 @@ var _ = Describe("Access-control non-root user,", func() {
 
 		By("Start test")
 		err = globalhelper.LaunchTests(
-			tsparams.TestCaseNameAccessControlNonRootUser,
+			tsparams.TestCaseNameAccessControlNonRootUserID,
 			globalhelper.ConvertSpecNameToFileName(CurrentSpecReport().FullText()), randomReportDir, randomCertsuiteConfigDir)
 		Expect(err).ToNot(HaveOccurred())
 
 		By("Verify test case status in Claim report")
 		err = globalhelper.ValidateIfReportsAreValid(
-			tsparams.TestCaseNameAccessControlNonRootUser,
+			tsparams.TestCaseNameAccessControlNonRootUserID,
 			globalparameters.TestCaseFailed, randomReportDir)
 		Expect(err).ToNot(HaveOccurred())
 	})

diff --git a/...s_control_container_non-root_user_test.go → ...ontrol_container_non-root_user_id_test.go b/...s_control_container_non-root_user_test.go → ...ontrol_container_non-root_user_id_test.go
diff --git a/tests/operator/tests/operator_non_root.go b/tests/operator/tests/operator_non_root.go
diff --git a/tests/operator/tests/operator_pod_automount_token.go b/tests/operator/tests/operator_pod_automount_token.go