Rebase the ginkgo_removal branch with main #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: sebrandon1 <sebrandon1@users.noreply.github.com>
After testing it in a private repo, it works when the webhook URL+query is surrounded by single quotes.
Co-authored-by: sebrandon1 <sebrandon1@users.noreply.github.com>
…r-k8s#1631) The bug happens when deploying pods with containers that don't have any cpu req/limit defined in its spec but they do have any other resource (like mem) set. cut.Resources.Requests and cut.Resources.Limits are maps, whose keys are the different resources (mem, cpu, hugepages) that were explicitly set in the container spec. Requests.Cpu() returns a defaulted (zeroed) Quantity for the cpu resource if that resource type doesn't exist in the requests map, which will happen if cpu reqs/limits are not explicitly set in the pod spec.
…ices-for-k8s#1633) Bumps ubi8/ubi from 8.8-1067.1698056881 to 8.9-1028. --- updated-dependencies: - dependency-name: ubi8/ubi dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…st-practices-for-k8s#1634) Bumps ubi8/ubi-minimal from 8.8-1072.1697626218 to 8.9-1029. --- updated-dependencies: - dependency-name: ubi8/ubi-minimal dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…k8s#1636) Bumps [k8s.io/kubectl](https://github.com/kubernetes/kubectl) from 0.28.3 to 0.28.4. - [Commits](kubernetes/kubectl@v0.28.3...v0.28.4) --- updated-dependencies: - dependency-name: k8s.io/kubectl dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: sebrandon1 <sebrandon1@users.noreply.github.com>
sebrandon1
merged commit 91ca052
into
redhat-best-practices-for-k8s:ginkgo_removal
7 checks passed
greyerof
pushed a commit
to greyerof/certsuite
that referenced
this pull request
Nov 21, 2023
The content of PR redhat-best-practices-for-k8s#1642 was accidentally removed from ginkgo_removal branch by commit 1c11b94.
Merged
sebrandon1
added a commit
that referenced
this pull request
Nov 21, 2023
sebrandon1
added a commit
to sebrandon1/certsuite
that referenced
this pull request
Nov 21, 2023
…s-for-k8s#1649) The content of PR redhat-best-practices-for-k8s#1642 was accidentally removed from ginkgo_removal branch by commit 1c11b94. Co-authored-by: Brandon Palm <bpalm@redhat.com>
sebrandon1
added a commit
to sebrandon1/certsuite
that referenced
this pull request
Nov 21, 2023
…s-for-k8s#1649) The content of PR redhat-best-practices-for-k8s#1642 was accidentally removed from ginkgo_removal branch by commit 1c11b94. Co-authored-by: Brandon Palm <bpalm@redhat.com>
sebrandon1
added a commit
to sebrandon1/certsuite
that referenced
this pull request
Nov 21, 2023
…s-for-k8s#1649) The content of PR redhat-best-practices-for-k8s#1642 was accidentally removed from ginkgo_removal branch by commit 1c11b94. Co-authored-by: Brandon Palm <bpalm@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.