-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: Add no hugepages test #2505
Merged
sebrandon1
merged 2 commits into
redhat-best-practices-for-k8s:main
from
sebrandon1:operator_pods_no_hugepages
Oct 16, 2024
Merged
operator: Add no hugepages test #2505
sebrandon1
merged 2 commits into
redhat-best-practices-for-k8s:main
from
sebrandon1:operator_pods_no_hugepages
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebrandon1
force-pushed
the
operator_pods_no_hugepages
branch
from
October 8, 2024 19:50
a549788
to
a064332
Compare
from change #2505: |
greyerof
approved these changes
Oct 9, 2024
sebrandon1
force-pushed
the
operator_pods_no_hugepages
branch
from
October 9, 2024 18:31
a064332
to
417d60d
Compare
from change #2505: |
sebrandon1
force-pushed
the
operator_pods_no_hugepages
branch
from
October 10, 2024 15:57
417d60d
to
9cd2047
Compare
from change #2505: |
jmontesi
approved these changes
Oct 11, 2024
sebrandon1
force-pushed
the
operator_pods_no_hugepages
branch
from
October 11, 2024 14:11
9cd2047
to
6cc98d0
Compare
from change #2505: |
sebrandon1
force-pushed
the
operator_pods_no_hugepages
branch
2 times, most recently
from
October 15, 2024 16:43
0e45077
to
f445b16
Compare
sebrandon1
force-pushed
the
operator_pods_no_hugepages
branch
from
October 15, 2024 17:02
f445b16
to
603195b
Compare
from change #2505:
|
/dci-rerun |
from change #2505: |
sebrandon1
merged commit Oct 16, 2024
8b7da6e
into
redhat-best-practices-for-k8s:main
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
operator
suite test for making sure they are not using hugepages in their pods that utilizes the existingpod.HasHugepages()
function.Note, I have left the test case as fully
Optional
for now until we discuss Mandatory or Optional as a group.