Task change assignee #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix merge between redhat-beyond#66 and redhat-beyond#72
- Create conftest.py for reusable fixtures
- Add change_assignee function to Task model. - Add tests for change_assignee
Asafh7
previously approved these changes
Nov 26, 2021
AvivLiberman
previously approved these changes
Nov 27, 2021
|
@orzionpour - Please add a meaningful description, In a human language - what is the change done in this PR - not which files are added etc. but something that your readers (including your future self) will understand. |
nunnatsa
reviewed
Nov 27, 2021
@nunnatsa |
- Removed use of Random to prevent unexpected behavior in tests. - Changed to named parameters in user creations.
orzionpour
requested review from
AvivLiberman,
Asafh7,
nunnatsa,
kobihk,
aradz1997,
avraham1992,
mgold1234 and
natifridman
nunnatsa
reviewed
Nov 27, 2021
Asafh7
previously approved these changes
Nov 27, 2021
- Add new tests to validate the correctness of the function in special cases.
- Add new user case handling: new_assignee is a user but not part of the system (not in DB) - Add corresponding test
kobihk
requested changes
Nov 28, 2021
avraham1992
previously approved these changes
Nov 28, 2021
Merged
kobihk
requested changes
Nov 28, 2021
kobihk
previously approved these changes
Nov 28, 2021
Asafh7
previously approved these changes
Nov 29, 2021
|
Resolved conflicts with #74 - can be merged now. |
kobihk
approved these changes
Nov 29, 2021
AvivLiberman
approved these changes
Nov 29, 2021
aradz1997
approved these changes
Nov 29, 2021
avraham1992
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77
This PR adds the ability to change the assigned employee of a given task in DB.
Changes you made
- Create conftest.py for reusable fixtures
Added fixtures that create a test DB we can use in future tests (and refactor previous tests to prevent code duplications that we already have).
- Add change_assignee function to Task model
This function is a Task instance's function that changes the assigned employee for the given task.
- Add change_assignee tests
Tests for change_assignee tests.