OCPBUGS-24595: Cloudeventproxy 2 Card WPC not able to handle multiple dependency and multiple ts2phcs #941
aneeshkpmain.yaml
on: pull_request
Linting
54s
Unit Tests
3m 59s
Annotations
11 errors and 9 warnings
|
Linting:
plugins/ptp_operator/metrics/logparser.go#L455
unnecessary conversion (unconvert)
|
|
Linting:
plugins/ptp_operator/event/event.go#L215
unnecessary trailing newline (whitespace)
|
|
Linting:
plugins/ptp_operator/event/event.go#L263
unnecessary trailing newline (whitespace)
|
|
Linting:
plugins/ptp_operator/stats/stats.go#L228
unnecessary trailing newline (whitespace)
|
|
Linting:
plugins/ptp_operator/event/event.go#L156
shadow: declaration of "ok" shadows declaration at line 100 (govet)
|
|
Linting
issues found
|
|
Unit Tests:
plugins/ptp_operator/event/event_test.go#L44
cannot use map[string]*event.ClockState{…} (value of type map[string]*event.ClockState) as map[string]event.DependingClockState value in struct literal
|
|
Unit Tests:
plugins/ptp_operator/event/event_test.go#L65
cannot use map[string]*event.ClockState{…} (value of type map[string]*event.ClockState) as map[string]event.DependingClockState value in struct literal
|
|
Unit Tests:
plugins/ptp_operator/event/event_test.go#L90
cannot use map[string]*event.ClockState{…} (value of type map[string]*event.ClockState) as map[string]event.DependingClockState value in struct literal
|
|
Unit Tests:
plugins/ptp_operator/metrics/metrics_test.go#L375
invalid argument: cannot make *stats.PTPStats; type must be slice, map, or channel
|
|
Unit Tests
Process completed with exit code 2.
|
|
Linting
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Linting:
plugins/ptp_operator/event/event.go#L41
exported: exported type DependingClockState should have comment or be unexported (revive)
|
|
Linting:
plugins/ptp_operator/event/event.go#L158
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
|
|
Linting:
plugins/ptp_operator/stats/stats.go#L225
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
|
|
Linting:
plugins/ptp_operator/stats/stats.go#L16
exported: exported type PTPStats should have comment or be unexported (revive)
|
|
Linting:
plugins/ptp_operator/stats/stats.go#L258
exported: exported method PTPStats.CheckSource should have comment or be unexported (revive)
|
|
Linting:
plugins/ptp_operator/stats/stats.go#L265
exported: exported method PTPStats.New should have comment or be unexported (revive)
|
|
Linting:
plugins/ptp_operator/metrics/logparser.go#L461
unused-parameter: parameter 'ptp4lCfg' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Unit Tests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|