Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.14] OCPBUGS-26237: Backport 2 WPC Cards to 4.14 #283

Merged
merged 6 commits into from
Jan 18, 2024

Conversation

jzding
Copy link
Member

@jzding jzding commented Jan 8, 2024

This backport includes the following PRs from release-4.15:
#265
Process ts2phc and dpll events for multi-cards

#268
Refactor and improve coverage on metrics unit tests

#276
[release-4.15] OCPBUGS-25411: Cloudeventproxy 2 Card WPC not able to handle multiple dependency and multiple ts2phcs

#280
[release-4.15] OCPBUGS-25691: PTP event getCurrentState for GNSS return event not found

#282
[release-4.15] OCPBUGS-26077: PTP metrics still includes metrics for old config after deleting a ptpconfig

#286
[release-4.15] OCPBUGS-27073: nmea_status parsing throws nil pointer exception

jzding and others added 5 commits January 8, 2024 17:55
Signed-off-by: Jack Ding <jackding@gmail.com>
Added events verification
Added more tests

Signed-off-by: Jack Ding <jackding@gmail.com>
Signed-off-by: Aneesh Puttur <aputtur@redhat.com>
Co-authored-by: Aneesh Puttur <aputtur@redhat.com>
Signed-off-by: Aneesh Puttur <aputtur@redhat.com>
Co-authored-by: Aneesh Puttur <aputtur@redhat.com>
@openshift-ci-robot
Copy link

@jzding: This pull request references Jira Issue OCPBUGS-26237, which is invalid:

  • expected the bug to target the "4.14.z" version, but no target version was set
  • expected Jira Issue OCPBUGS-26237 to depend on a bug targeting a version in 4.15.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This backport includes the following PRs from release-4.15:
#265
Process ts2phc and dpll events for multi-cards

#268
Refactor and improve coverage on metrics unit tests

#276
[release-4.15] OCPBUGS-25411: Cloudeventproxy 2 Card WPC not able to handle multiple dependency and multiple ts2phcs

#280
[release-4.15] OCPBUGS-25691: PTP event getCurrentState for GNSS return event not found

#282
[release-4.15] OCPBUGS-26077: PTP metrics still includes metrics for old config after deleting a ptpconfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jzding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 8, 2024
@jzding
Copy link
Member Author

jzding commented Jan 8, 2024

/jira refresh

@openshift-ci-robot
Copy link

@jzding: This pull request references Jira Issue OCPBUGS-26237, which is invalid:

  • expected the bug to target the "4.14.z" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jzding
Copy link
Member Author

jzding commented Jan 8, 2024

/jira refresh

@openshift-ci-robot
Copy link

@jzding: This pull request references Jira Issue OCPBUGS-26237, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-26496 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-26496 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (bblock@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jzding jzding changed the title [release-4.14] Bug OCPBUGS-26237: Backport 2 WPC Cards to 4.14 [release-4.14] OCPBUGS-26237: Backport 2 WPC Cards to 4.14 Jan 11, 2024
Signed-off-by: Aneesh Puttur <aputtur@redhat.com>
@openshift-ci-robot
Copy link

@jzding: This pull request references Jira Issue OCPBUGS-26237, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-26496 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-26496 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (bblock@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This backport includes the following PRs from release-4.15:
#265
Process ts2phc and dpll events for multi-cards

#268
Refactor and improve coverage on metrics unit tests

#276
[release-4.15] OCPBUGS-25411: Cloudeventproxy 2 Card WPC not able to handle multiple dependency and multiple ts2phcs

#280
[release-4.15] OCPBUGS-25691: PTP event getCurrentState for GNSS return event not found

#282
[release-4.15] OCPBUGS-26077: PTP metrics still includes metrics for old config after deleting a ptpconfig

#286
[release-4.15] OCPBUGS-27073: nmea_status parsing throws nil pointer exception

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@josephdrichard
Copy link

/lgtm

@Bonnie-Block
Copy link

/label cherry-pick-approved

Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

@Bonnie-Block: The label(s) cherry-pick-approved cannot be applied, because the repository doesn't have them.

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jzding jzding merged commit 03d3d46 into redhat-cne:release-4.14 Jan 18, 2024
4 of 5 checks passed
@openshift-ci-robot
Copy link

@jzding: Jira Issue OCPBUGS-26237: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-26237 has been moved to the MODIFIED state.

In response to this:

This backport includes the following PRs from release-4.15:
#265
Process ts2phc and dpll events for multi-cards

#268
Refactor and improve coverage on metrics unit tests

#276
[release-4.15] OCPBUGS-25411: Cloudeventproxy 2 Card WPC not able to handle multiple dependency and multiple ts2phcs

#280
[release-4.15] OCPBUGS-25691: PTP event getCurrentState for GNSS return event not found

#282
[release-4.15] OCPBUGS-26077: PTP metrics still includes metrics for old config after deleting a ptpconfig

#286
[release-4.15] OCPBUGS-27073: nmea_status parsing throws nil pointer exception

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cloud-event-proxy-container-v4.14.0-202401190511.p0.g03d3d46.assembly.stream for distgit cloud-event-proxy.
All builds following this will include this PR.

@jzding jzding deleted the 2cards-4.14 branch April 24, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants