Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.14] OCPBUGS-26269: Fix SAST scanning issues CWE-209 CWE-23 #290

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

jzding
Copy link
Member

@jzding jzding commented Feb 13, 2024

No description provided.

Signed-off-by: Jack Ding <jackding@gmail.com>
@openshift-ci-robot
Copy link

@jzding: This pull request references Jira Issue OCPBUGS-26269, which is invalid:

  • expected the bug to target the "4.14.z" version, but no target version was set
  • expected Jira Issue OCPBUGS-26269 to depend on a bug targeting a version in 4.15.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jzding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jzding
Copy link
Member Author

jzding commented Feb 13, 2024

/jira refresh

@openshift-ci-robot
Copy link

@jzding: This pull request references Jira Issue OCPBUGS-26269, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-23596 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-23596 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @yliu127

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127.

Note that only redhat-cne members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@jzding: This pull request references Jira Issue OCPBUGS-26269, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-23596 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-23596 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @yliu127

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aneeshkp
Copy link
Member

aneeshkp commented Mar 4, 2024

/label backport-risk-assessed

Copy link
Contributor

openshift-ci bot commented Mar 4, 2024

@aneeshkp: The label(s) backport-risk-assessed cannot be applied, because the repository doesn't have them.

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aneeshkp
Copy link
Member

aneeshkp commented Mar 4, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 4, 2024
@jzding jzding merged commit f1d489e into redhat-cne:release-4.14 Mar 4, 2024
4 of 5 checks passed
@openshift-ci-robot
Copy link

@jzding: Jira Issue OCPBUGS-26269: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-26269 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cloud-event-proxy-container-v4.14.0-202403042308.p0.gf1d489e.assembly.stream.el8 for distgit cloud-event-proxy.
All builds following this will include this PR.

@hhassid
Copy link

hhassid commented Mar 6, 2024

/label cherry-pick-approved

Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@hhassid: The label(s) cherry-pick-approved cannot be applied, because the repository doesn't have them.

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jzding jzding deleted the SAST-fix-4.14 branch April 24, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants