PTP Events Generating Redundant Noise for Repeated FREERUN State Transitions #365
Conversation
|
@aneeshkp: This pull request references Jira Issue OCPBUGS-43643, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@aneeshkp: This pull request references Jira Issue OCPBUGS-43643, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yliu127. Note that only redhat-cne members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
aneeshkp
force-pushed
the
reduce-event-noise
branch
from
cb85807
to
8261fcf
Compare
| } | ||
| log.Warnf("%s sync state %s, last ptp state is unknown, setting to %s", eventResourceName, clockState, lastClockState) |
There was a problem hiding this comment.
this is wrong, should be
log.Warnf("%s sync state %s, last ptp state %s is unknown, setting to %s", eventResourceName, ptp.LOCKED, lastClockState, clockState)
| if lastClockState != ptp.FREERUN { // don't send event if last event was freerun | ||
| log.Infof(" publishing event for (profile %s) %s with last state %s and current clock state %s and offset %d for ( Max/Min Threshold %d/%d )", | ||
| ptpProfileName, eventResourceName, oStats.LastSyncState(), clockState, ptpOffset, threshold.MaxOffsetThreshold, threshold.MinOffsetThreshold) | ||
| p.PublishEvent(clockState, ptpOffset, eventResourceName, eventType) // change to locked |
There was a problem hiding this comment.
remove the comment. it is change to freerun, not locaked
There was a problem hiding this comment.
addressed the issue and made few changes, please review again
aneeshkp
force-pushed
the
reduce-event-noise
branch
2 times, most recently
from
31f11fe
to
0928ced
Compare
…sitions Signed-off-by: Aneesh Puttur <aputtur@redhat.com>
aneeshkp
force-pushed
the
reduce-event-noise
branch
from
0928ced
to
0eb7275
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aneeshkp, jzding The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 6aefbbe
into
redhat-cne:main
|
@aneeshkp: Jira Issue OCPBUGS-43643: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-43643 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: cloud-event-proxy |
aneeshkp
changed the title
Fixes issue introduced in this PR #352
PR Description:
This PR addresses the issue of redundant PTP events being generated when the system repeatedly sends events indicating the FREERUN state, even though the previous state was already FREERUN. This behavior introduces unnecessary noise in the event stream, making it harder to track meaningful state changes and creating clutter in logs and monitoring systems.
Changes Introduced:
State transition logic updated to prevent duplicate events when the system remains in the same FREERUN state.