Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O-RAN V3 Rest Api: Event Subscription #70

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

jzding
Copy link
Member

@jzding jzding commented Jun 21, 2024

No description provided.

Signed-off-by: Jack Ding <jackding@gmail.com>
@jzding jzding changed the title O-RAN V3 Compliant Producer Rest Api: Event Subscription [WIP] O-RAN V3 Compliant Producer Rest Api: Event Subscription Jun 21, 2024
@jzding jzding changed the title [WIP] O-RAN V3 Compliant Producer Rest Api: Event Subscription [WIP] O-RAN V3 Rest Api: Event Subscription Jun 21, 2024
@jzding jzding force-pushed the oran-api branch 18 times, most recently from cc867ce to 0829bf8 Compare June 25, 2024 19:44
@jzding jzding changed the title [WIP] O-RAN V3 Rest Api: Event Subscription O-RAN V3 Rest Api: Event Subscription Jun 25, 2024
Copy link

@josephdrichard josephdrichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jzding jzding force-pushed the oran-api branch 3 times, most recently from c16f88e to ba70d27 Compare June 28, 2024 17:19
pkg/restclient/client.go Outdated Show resolved Hide resolved
v2/routes.go Outdated Show resolved Hide resolved
id := uuid.New().String()
sub.SetID(id)
sub.SetVersion(API_VERSION)
sub.SetURILocation(fmt.Sprintf("http://localhost:%d%s%s/%s", s.port, s.apiPath, "subscriptions", sub.ID)) //nolint:errcheck

newSub, err := s.pubSubAPI.CreateSubscription(sub)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need local pubsub anymore, since we are using configmap

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added note, will do in the next story

Signed-off-by: Jack Ding <jackding@gmail.com>
@jzding jzding requested a review from aneeshkp July 3, 2024 14:58
@jzding jzding merged commit da39815 into redhat-cne:main Jul 3, 2024
2 checks passed
jzding added a commit to jzding/rest-api that referenced this pull request Aug 29, 2024
* cp routes.go server.go server_test.go swagger.json to v2

Signed-off-by: Jack Ding <jackding@gmail.com>

* O-RAN V3 Rest Api: Event Subscription

Signed-off-by: Jack Ding <jackding@gmail.com>

---------

Signed-off-by: Jack Ding <jackding@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants