CNF-13067: O-RAN V3 Rest Api: Status Notification #71
Conversation
jzding
force-pushed
the
oran-api
branch
5 times, most recently
from
c30f8a7
to
3db84e4
Compare
| @@ -67,26 +67,19 @@ func (s *Server) createSubscription(w http.ResponseWriter, r *http.Request) { | |||
| localmetrics.UpdateSubscriptionCount(localmetrics.FAILCREATE, 1) | |||
| return | |||
| } | |||
| if subExists, ok := s.pubSubAPI.HasSubscription(sub.GetResource()); ok { | |||
| clientIDs := s.subscriberAPI.GetClientIDByResource(sub.GetResource()) | |||
There was a problem hiding this comment.
should be one clientID for the resource
There was a problem hiding this comment.
This returns clientIDs []uuid.UUID. I did not change the logic.
https://github.com/redhat-cne/sdk-go/blob/main/v1/subscriber/subscriber.go#L254
| ce.SetDataContentType(cloudevents.ApplicationJSON) | ||
| ce.SetSpecVersion(cloudevents.VersionV03) | ||
| ce := cloudevents.NewEvent(cloudevents.VersionV1) | ||
| ce.SetSpecVersion(cloudevents.VersionV1) |
There was a problem hiding this comment.
In O-RAN V3.0 spec, Event Data Model (chapter 7.2.2) does not have datacontenttype and subject, so I removed them.
There was a problem hiding this comment.
Subject is used by cloudEvent proxy it is internally used
https://github.com/redhat-cne/cloud-event-proxy/blob/d9e98a115ad764a2d15a4ab5b36594b2228d333c/examples/simplehttp/common/subscribe.go#L48
There was a problem hiding this comment.
also it is used by cloudevents specs https://github.com/cloudevents/spec/blob/main/cloudevents/spec.md#example
There was a problem hiding this comment.
removed ce.SetSubject() from simplehttp. I think we are fine here. The subject is not actually used in internal API. The ProcessOutChannel() only uses Status and Action.
https://github.com/redhat-cne/cloud-event-proxy/blob/main/cmd/main.go#L219
jzding
force-pushed
the
oran-api
branch
2 times, most recently
from
c297afc
to
00cbdce
Compare
|
Please add description to this PR |
| @@ -49,7 +49,7 @@ type Subscriber struct { | |||
| SubStore *store.PubSubStore `json:"subStore" omit:"empty"` | |||
| // EndPointURI - A URI describing the subscriber link . | |||
| // +required | |||
| EndPointURI *types.URI `json:"endPointURI" omit:"empty"` | |||
There was a problem hiding this comment.
is it possible the internal API direct call failure in older version ?
There was a problem hiding this comment.
no. tested with old version. The subscription was successful.
| @@ -84,8 +84,8 @@ func (s *Subscriber) FailedCount() int { | |||
| // String returns a pretty-printed representation of the Event. | |||
| func (s *Subscriber) String() string { | |||
| b := strings.Builder{} | |||
| b.WriteString(" EndPointURI: " + s.GetEndPointURI() + "\n") | |||
| b.WriteString(" ID: " + s.GetClientID().String() + "\n") | |||
There was a problem hiding this comment.
no. tested with old version. The subscription was successful.
done |
jzding
force-pushed
the
oran-api
branch
2 times, most recently
from
b1356a1
to
becd572
Compare
Signed-off-by: Jack Ding <jackding@gmail.com>
Signed-off-by: Jack Ding <jackding@gmail.com>
More details in doc https://docs.google.com/document/d/1aIgGWhFDDz9aI7mIZm_nlkb99UrV7hv5gS5m_XShCt4/edit