Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2033404: Add source in event #37

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Conversation

jzding
Copy link
Member

@jzding jzding commented Dec 30, 2021

  • Add source as a required attribute in event.
  • Update the resource under event.data.values to be resource type instead of the source.

Signed-off-by: Jack Ding jacding@redhat.com

@jzding jzding changed the title Add source in event Bug 2033404: Add source in event Dec 30, 2021
Add `source` as a required attribute in event.
Update the `resource` under `event.data.values` to be resource
type instead of the source.

Signed-off-by: Jack Ding <jacding@redhat.com>
Copy link
Member

@aneeshkp aneeshkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aneeshkp
Copy link
Member

aneeshkp commented Jan 5, 2022

/lgtm

@jzding jzding merged commit b17827c into redhat-cne:main Jan 5, 2022
@jzding jzding deleted the source-type branch December 12, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants