Redfish schema change to support HPE events and multiple EventRecords #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Events sent from HPE BMCs have older version Event schema (Event.v1_0_0). There are also possiblilies that some vendors are not fully Redfish compatible by missing some required attributes. For example HPE events miss the required attribute `Id` in Event schema. Log warnings instead of fail the marshalling when some required fields are missing to make the hw-event-proxy accept older version or incompatible events. Fix marchalling to suppor multiple EventRecords to be included in the same Event. Signed-off-by: Jack Ding <jacding@redhat.com>
aneeshkp
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Events sent from HPE BMCs have older version Event schema (Event.v1_0_0).
There are also possiblilies that some vendors are not fully Redfish
compatible by missing some required attributes. For example HPE events
miss the required attribute
Idin Event schema.Log warnings instead of fail the marshalling when some required fields
are missing to make the hw-event-proxy accept older version or
incompatible events.
Fix marchalling to suppor multiple EventRecords to be included in the
same Event.
Signed-off-by: Jack Ding jacding@redhat.com