Event source was lost when converting cloud native events to events. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is fixed by copy native events source to cloud events subject bus address is set to the source of cloud events. When unpacking from cloud events to cloud-native events, the process needs to copy the subject back to cloud events Signed-off-by: Aneesh Puttur <aneeshputtur@gmail.com>
|
/lgtm |
jzding
approved these changes
Mar 24, 2022
aneeshkp
added a commit
to aneeshkp/sdk-go-1
that referenced
this pull request
Mar 24, 2022
…edhat-cne#39) This is fixed by copy native events source to cloud events subject bus address is set to the source of cloud events. When unpacking from cloud events to cloud-native events, the process needs to copy the subject back to cloud events Signed-off-by: Aneesh Puttur <aneeshputtur@gmail.com> Add subject to v1 events , refers toevent library in package , which was missed in last commit
aneeshkp
added a commit
to aneeshkp/sdk-go-1
that referenced
this pull request
Mar 24, 2022
…edhat-cne#39) This is fixed by copy native events source to cloud events subject bus address is set to the source of cloud events. When unpacking from cloud events to cloud-native events, the process needs to copy the subject back to cloud events Signed-off-by: Aneesh Puttur <aneeshputtur@gmail.com> Add subject to v1 events , refers toevent library in package , which was missed in last commit
aneeshkp
added a commit
to aneeshkp/sdk-go-1
that referenced
this pull request
Mar 24, 2022
…edhat-cne#39) This is fixed by copy native events source to cloud events subject bus address is set to the source of cloud events. When unpacking from cloud events to cloud-native events, the process needs to copy the subject back to cloud events Signed-off-by: Aneesh Puttur <aneeshputtur@gmail.com> Add subject to v1 events , refers toevent library in package , which was missed in last commit Event source was lost when converting cloud native events to events This is fixed by copy native events source to cloud events subject bus address is set to the source of cloud events. When unpacking from cloud events to cloud-native events, the process needs to copy the subject back to cloud events Signed-off-by: Aneesh Puttur <aneeshputtur@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixed by copy native events source to cloud events subject
bus address is set to the source of cloud events.
When unpacking from cloud events to cloud-native events, the process needs to copy the subject back to cloud events
Signed-off-by: Aneesh Puttur aneeshputtur@gmail.com