Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug OCPBUGS-8003: Cloud-event-proxy should stop sending events to the dead clients #83

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

aneeshkp
Copy link
Member

This PR fixes

  1. Subscribers not deleted when a client goes away
  2. subscriber and event response was not available via cloud event send operation which was causing error reporting in logs
  3. updated metrics by renaming amq to transport

docs/metrics.md Outdated

`cne_amqp_events_received` - The number of events received by the amqp protocol, and their status by address.
`cne_transport_events_received` - The number of events received by the transport protocol, and their status by address.

Example
```json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks bad, use ```console instead. Same for other occurrences.

@jzding jzding changed the title OCPBUGS-8003: Cloud-event-proxy should stop sending events to the dead clients Bug OCPBUGS-8003: Cloud-event-proxy should stop sending events to the dead clients Feb 28, 2023
Signed-off-by: Aneesh Puttur <aneeshputtur@gmail.com>
@aneeshkp aneeshkp force-pushed the modify-subscription-api branch from 7dbf075 to 42df6b7 Compare February 28, 2023 22:20
Copy link
Member

@jzding jzding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@aneeshkp aneeshkp merged commit bdf039f into redhat-cne:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants