fix deleting of subscriber and recovering #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if err = h.NewSender(obj.ClientID, obj.GetEndPointURI()); err != nil { | ||
| log.Errorf("(1)error creating subscriber %v for address %s", err, obj.GetEndPointURI()) | ||
| localmetrics.UpdateSenderCreatedCount(obj.GetEndPointURI(), localmetrics.FAILED, 1) | ||
| } else if _, err = h.subscriberAPI.CreateSubscription(obj.ClientID, obj); err != nil { | ||
| log.Infof("failed creating subscription for %s", obj.ClientID.String()) | ||
| out.Status = channel.FAILED |
There was a problem hiding this comment.
you dont need this line as you are setting status to failed just before the if/else block. That being said you are better off just setting the status in each if/else condition for better readability
pkg/protocol/http/http.go
Outdated
| if err = h.NewSender(obj.ClientID, obj.GetEndPointURI()); err != nil { | ||
| log.Errorf("(1)error creating subscriber %v for address %s", err, obj.GetEndPointURI()) | ||
| localmetrics.UpdateSenderCreatedCount(obj.GetEndPointURI(), localmetrics.FAILED, 1) | ||
| } else if _, err = h.subscriberAPI.CreateSubscription(obj.ClientID, obj); err != nil { | ||
| log.Infof("failed creating subscription for %s", obj.ClientID.String()) |
Signed-off-by: Aneesh Puttur <aneeshputtur@gmail.com>
nishant-parekh
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue: the client does not recover if a client comes back after it is marked for delete due to inactivity.