-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ansible-lint #21
Conversation
6287d81
to
aca61b4
Compare
document-start: disable | ||
|
||
line-length: disable | ||
truthy: disable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove this? it is a good ansible practice to restrict boolean values to true
and false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allowed values should also be False and True. By default truthy allows only ['true', 'false']. At this point, not sure if we should define a custom list or keep it disabled.
@@ -0,0 +1,5 @@ | |||
minor_changes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if we really need a changelog as the collection has no release yet
It looks like we still need the zuul config for this repo. Ideally, we should get that set up before merging this. |
I opened these to set that: ansible/ansible-zuul-jobs#1664 |
recheck |
Build failed. ❌ ansible-tox-linters FAILURE in 4m 04s |
Build failed. ❌ ansible-tox-linters FAILURE in 4m 07s |
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
721f817
to
13bdd5b
Compare
Build failed. ❌ ansible-tox-linters FAILURE in 4m 08s |
recheck |
Build failed. ❌ ansible-tox-linters FAILURE in 4m 23s |
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Build failed. ❌ ansible-tox-linters FAILURE in 4m 43s |
recheck |
Build failed. ❌ ansible-tox-linters FAILURE in 4m 19s |
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 4m 30s |
SUMMARY
Enable ansible-lint
ISSUE TYPE