Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ansible-lint #21

Merged
merged 10 commits into from
Nov 11, 2022
Merged

Conversation

alinabuzachis
Copy link
Contributor

@alinabuzachis alinabuzachis commented Oct 24, 2022

SUMMARY

Enable ansible-lint

ISSUE TYPE
  • Docs Pull Request

@alinabuzachis alinabuzachis force-pushed the enable_ansible-lint branch 2 times, most recently from 6287d81 to aca61b4 Compare October 26, 2022 13:39
document-start: disable

line-length: disable
truthy: disable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this? it is a good ansible practice to restrict boolean values to true and false

Copy link
Contributor Author

@alinabuzachis alinabuzachis Oct 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowed values should also be False and True. By default truthy allows only ['true', 'false']. At this point, not sure if we should define a custom list or keep it disabled.

@@ -0,0 +1,5 @@
minor_changes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we really need a changelog as the collection has no release yet

@gravesm
Copy link
Member

gravesm commented Oct 27, 2022

It looks like we still need the zuul config for this repo. Ideally, we should get that set up before merging this.

@alinabuzachis
Copy link
Contributor Author

It looks like we still need the zuul config for this repo. Ideally, we should get that set up before merging this.

I opened these to set that:

ansible/ansible-zuul-jobs#1664
ansible/zuul-config#458
ansible/zuul-config#459

@alinabuzachis
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.

ansible-tox-linters FAILURE in 4m 04s

@softwarefactory-project-zuul
Copy link

Build failed.

ansible-tox-linters FAILURE in 4m 07s

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@softwarefactory-project-zuul
Copy link

Build failed.

ansible-tox-linters FAILURE in 4m 08s

@alinabuzachis
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.

ansible-tox-linters FAILURE in 4m 23s
✔️ build-ansible-collection SUCCESS in 4m 40s

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@softwarefactory-project-zuul
Copy link

Build failed.

ansible-tox-linters FAILURE in 4m 43s
✔️ build-ansible-collection SUCCESS in 4m 46s

@alinabuzachis
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.

ansible-tox-linters FAILURE in 4m 19s

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ ansible-tox-linters SUCCESS in 4m 30s

@jillr jillr merged commit cfa0563 into redhat-cop:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants