Fixes to make this work with Controller #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed to work with AAP on AWS. |
jillr
requested changes
Aug 11, 2023
There was a problem hiding this comment.
Thanks for this @HichamMourad. One small item, otherwise this lgtm.
playbooks/webapp/tasks/create.yaml
Outdated
| @@ -43,6 +43,10 @@ | |||
| ansible.builtin.set_fact: | |||
| shared_az: "{{ region_av_zones[0] }}" | |||
|
|
|||
| - name: Print the value of Subnet_cidr | |||
There was a problem hiding this comment.
I don't think this debug task is needed.
There was a problem hiding this comment.
made the change. Thanks.
|
This PR will also need a changelog |
|
@HichamMourad can you please add a changelog? The milestone sanity failures are unrelated to this change, I'll make sure we have a ticket in the backlog to get that addressed for this repo (and the other validated content repos). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a few fixes to make this work with Automation controller. Also needed to update the Postgres version.