multi-cluster-multi-branch-jee/pipelineJEE8.groovy - ensure ansible applyer runs against correct clusters using API and token #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@etsauer can I get a review? |
|
@itewk whats actually changed in the PR, as the diff shows every line - presume line endings changed. are you able to tweak the PR to only show changes? |
|
@garethahealy sorry about that. had to fix line endings too. If you just click on the individual changes it will show you. |
|
@itewk ; no worries. once conflicts fixed, happy to merge. |
…pplyer runs against correct clusters using API and token
…nkins SA for CICD namespace to fix chicken/egg problem
|
@garethahealy fixed. |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently the pipeline is running the ansible code against the wrong clusters using the wrong API token, this fixes that.
How should this be tested?
Tested with sample deployment.
Is there a relevant Issue open for this?
No
Who would you like to review this?
cc: @redhat-cop/containers-approvers