Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create critical_services as documented by ansible for use with loop. #300

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

schabrolles
Copy link
Contributor

@schabrolles schabrolles commented Nov 24, 2022

When using with recent version of ansible-core (>2.12) playbook crashes with the following error:

module.helpernode.null_resource.config (remote-exec): TASK [Enable restart always for critical services] *****************************
module.helpernode.null_resource.config (remote-exec): fatal: [10.3.98.50]: FAILED! => {"msg": "Invalid data passed to 'loop', it requires a list, got this instead: ['httpd', 'named', 'haproxy'] + [ 'dhcpd' ]. Hint: If you passed a list/dict of just one element, try adding wantlist=True to your lookup invocation or use q/query instead of lookup."}

Some variables set during set_facts.yaml need to be set properly in order to be interpreted as list and not string.

@schabrolles
Copy link
Contributor Author

Hi there,

Is somebody could have a look at this one. One of our partner cannot deploy Openshift on a bastion with rhel8.6.

@prb112
Copy link
Contributor

prb112 commented Dec 5, 2022

@schabrolles I hit the same recently and used your fix. perhaps mention the install team that references this code? maybe the powervm/powervs?

Thanks for the fix, I used it with my team

@prb112
Copy link
Contributor

prb112 commented Jan 11, 2023

Hey @schabrolles I fixed this with the following:

$ yum remove ansible-core
$ yum install ansible-core-2.12.2-3.el8.ppc64le

@schabrolles
Copy link
Contributor Author

@here .... hello ... Is there anybody out there ?

Without this kind of patch, helpernode script is not usable anymore with "supported RH distro". Could you please have a look on it ?

@prb112
Copy link
Contributor

prb112 commented Jan 19, 2023

Hi @manojnkumar you might be interested in this one. and the powervs upi related bug.

@yussufsh
Copy link
Contributor

@christianh814 could you please help?

@lautou
Copy link
Contributor

lautou commented Jan 23, 2023

#304

@christianh814 christianh814 merged commit 41512bc into redhat-cop:devel Jan 25, 2023
@yussufsh
Copy link
Contributor

Thanks @christianh814 for merging this one. 👍

@prb112
Copy link
Contributor

prb112 commented Jan 25, 2023

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants