Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Create test resources for go library and avoid using external repos #155

Closed
Tracked by #166
thepetk opened this issue Mar 24, 2023 · 4 comments · Fixed by #198
Closed
Tracked by #166

Create test resources for go library and avoid using external repos #155

thepetk opened this issue Mar 24, 2023 · 4 comments · Fixed by #198
Assignees
Labels
area/test-automation Issues related to testing kind/enhancement New feature or request

Comments

@thepetk
Copy link
Collaborator

thepetk commented Mar 24, 2023

Which area this feature is related to?

/area test

Issue details

There are files like git_test.json that are providing external repos as test resources. This makes alizer's test depend to the status of those repos. We should use mocked or test resources instead of this, in order to be sure that our test have always the same resources

Target date: 11 May 2023

@openshift-ci openshift-ci bot added the area/test-automation Issues related to testing label Mar 24, 2023
@thepetk thepetk moved this to Backlog in Sprint 234 Mar 24, 2023
@thepetk thepetk added the kind/enhancement New feature or request label Mar 27, 2023
@thepetk thepetk removed this from Sprint 234 Mar 30, 2023
@jasperchui jasperchui mentioned this issue Mar 31, 2023
14 tasks
@thepetk thepetk self-assigned this Apr 5, 2023
@thepetk
Copy link
Collaborator Author

thepetk commented Apr 12, 2023

Update: Working on a PR that will include all those external repos inside the code and avoid cloning those projects every time a build is run.

@thepetk
Copy link
Collaborator Author

thepetk commented Apr 13, 2023

I've been working on 2 workarounds:

  1. Import all repos mentioned inside git_test.json inside this repository and replace github URL to local dir path (plus some updates in the git_test functionality). The issue here is that the alizer repo will become huge after this update as a lot of new files must be created.
  2. We can create a new repo which will be inside devfiles team and add every repo mentioned inside git_test.json to this repo as a directory. This way again we will have to clone from git in order to perform testing. As a plus, we do not need to make changes except than updating the git_test.json

@thepetk
Copy link
Collaborator Author

thepetk commented Apr 28, 2023

Update: I've created the https://github.com/devfile-resources/alizer-test-resources repo in order to import there all test resources of Alizer. I've added them all in this PR

@thepetk thepetk moved this to Review in Progress in Alizer Project May 3, 2023
@thepetk thepetk mentioned this issue May 3, 2023
@thepetk thepetk moved this from Review in Progress to In Progress in Alizer Project May 4, 2023
@thepetk thepetk moved this from In Progress to Review in Progress in Alizer Project May 5, 2023
@thepetk
Copy link
Collaborator Author

thepetk commented May 8, 2023

Update: The alizer test resources repo is fully updated and the PR is now ready for review

@github-project-automation github-project-automation bot moved this from Review in Progress to Done in Alizer Project May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/test-automation Issues related to testing kind/enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant