Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Onboard Alizer #166

Closed
14 tasks done
jasperchui opened this issue Mar 31, 2023 · 13 comments
Closed
14 tasks done

Onboard Alizer #166

jasperchui opened this issue Mar 31, 2023 · 13 comments
Assignees
Labels
2023Q2 kind/epic A high level requirement that can/should be split into smaller issues

Comments

@jasperchui jasperchui added kind/epic A high level requirement that can/should be split into smaller issues 2023Q2 labels Mar 31, 2023
@jasperchui jasperchui moved this to In Progress in Sprint 234 Mar 31, 2023
@thepetk
Copy link
Collaborator

thepetk commented Apr 4, 2023

@thepetk thepetk removed this from Sprint 234 Apr 4, 2023
@mike-hoang
Copy link
Contributor

mike-hoang commented Apr 13, 2023

Potential issues for this epic:
After removing js and java implementation, we'll use #177 to remove duplicated resource files to better organize the repo

@thepetk
Copy link
Collaborator

thepetk commented Apr 14, 2023

This one I'd say too:

@elsony
Copy link
Collaborator

elsony commented Apr 18, 2023

Other things that can be considered to be added as part of this Epic (feel free to cross out if they are already done):

  1. Improve code comments
  2. License change from EPL->Apache to align with the devfile project
  3. Set up the build system for proper release build
  4. Define the communication channels of the project
  5. Review existing documentation: identify the gaps and create items to track
  6. Set up proper PR test
  7. Set up nightly test run that consumes entries in the community devfile registry and product registry - I am ok to move it out to a separate item if we want to reduce the scope of this item

@thepetk
Copy link
Collaborator

thepetk commented Apr 19, 2023

@elsony , @jasperchui and @mike-hoang I've created/updated all issues.
Re 1: I've updated the #154 to include this action too.
Re 2: We have already created #176 but it wasn't included in this epic. I think this should be done after the onboarding to the new organization (same as #180 for dependabot).
Re 3: Created #186
Re 4: As a part of devfiles team, shouldn't have the same channels?
Re 5: The documentation has been updated with #151 , #149 and we also have the #185
Re 6: For PR testing, we have opened #173 in order to remove all unnecessary checks. We are aiming to keep only the go tests. IMO they are sufficient as we have unit tests for language, devfile, component recognition (additional cases for ports) and e2e tests with the git_test tests.
Re 7: Created #187 (I'd say it can be one of the first issues after the onboarding to devfiles)

After this input the updated list of issues should be:

[Remove Deprecated Implementations]

[Update documentation, tests and build processes]

[Improve functionality]

WDYT?

@jasperchui
Copy link
Author

Re 2: We have already created #176 but it wasn't included in this epic. I think this should be done after the onboarding to the new organization (same as #180 for dependabot).
We should complete this in this EPIC.

@elsony
Copy link
Collaborator

elsony commented Apr 21, 2023

Thanks for the updates. The rest looks ok and I only have extra comments for two of them:
4: I am fine with using the devfile communication channel. Having said that, people who finds to the Alizer project currently won't know who and where to contact. We need to have it mentioned somewhere.
6: Do we have test cases for all types of applications that we intended to support? What is the current code coverage?

@thepetk
Copy link
Collaborator

thepetk commented Apr 23, 2023

@elsony (cc @mike-hoang & @jasperchui)

4: I am fine with using the devfile communication channel. Having said that, people who finds to the Alizer project currently won't know who and where to contact. We need to have it mentioned somewhere.

Maybe I have misinterpreted the issue. I mean that after the onboarding, we can have the same channels as the devfiles. Before that, I'd propose that we can create a dedicated internal channel for this issue (e.g forum-alizer) and for the outerloop I'd say we can continue relying on the github issues. So, any person who want to communicate about alizer they would have to create an issue.

6: Do we have test cases for all types of applications that we intended to support? What is the current code coverage?

I've created the coverage.csv which lists all paths/functions that don't have coverage 100%. The average coverage is: 78.60%.

In order to improve this number I've created the #194 with all cases that are missing from component (and port) & devfile detection.

@michael-valdron
Copy link
Member

Could we update the acceptance criteria for this epic to include the additional child issues mentioned in the story?

cc: @thepetk @mike-hoang

@thepetk
Copy link
Collaborator

thepetk commented Jun 1, 2023

Yes I'll do that soon :)

@thepetk
Copy link
Collaborator

thepetk commented Jun 1, 2023

I've updated the list of tasks remaining for the onboarding

@thepetk
Copy link
Collaborator

thepetk commented Jun 13, 2023

I've updated the acceptance criteria for the EPIC. I've removed #226 from the list as it is blocked and the onboarding can be done even if is not completed

@jasperchui jasperchui moved this from Todo to In Progress in Alizer Project Jun 23, 2023
@thepetk
Copy link
Collaborator

thepetk commented Jun 23, 2023

Some details about the final list:

@github-project-automation github-project-automation bot moved this from In Progress to Done in Alizer Project Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2023Q2 kind/epic A high level requirement that can/should be split into smaller issues
Projects
Status: Done
Development

No branches or pull requests

5 participants