Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Add min-version and max-version CLI arguments #226

Closed
Tracked by #159
thepetk opened this issue Jun 1, 2023 · 6 comments
Closed
Tracked by #159

Add min-version and max-version CLI arguments #226

thepetk opened this issue Jun 1, 2023 · 6 comments
Assignees
Labels
area/cli CLI related issues

Comments

@thepetk
Copy link
Collaborator

thepetk commented Jun 1, 2023

Which area/kind this issue is related to?

/area cli

Issue Description

As part of the proposal for #159 two CLI arguments have to be introduced. First the min-version and then the max-version args. As stated in the proposal the min version represents the minimum version of the matched devfile and the max version the maximum. In case the minimum version is greater than the maximum an error should be raised.

Target Date: 30 June 2023

@thepetk thepetk self-assigned this Jun 1, 2023
@openshift-ci openshift-ci bot added the area/cli CLI related issues label Jun 1, 2023
@thepetk thepetk moved this to Todo in Alizer Project Jun 1, 2023
This was referenced Jun 1, 2023
@thepetk thepetk moved this from Todo to In Progress in Alizer Project Jun 4, 2023
@thepetk thepetk mentioned this issue Jun 4, 2023
2 tasks
@thepetk
Copy link
Collaborator Author

thepetk commented Jun 4, 2023

I've created the #234 but I'm also having some issues with fetching the devfiles from v2index. When we are using x.x.x version or 1.x version it returns 500.

@thepetk
Copy link
Collaborator Author

thepetk commented Jun 12, 2023

I've created an issue in the devfile-api (devfile/api#1128) in order fix the above behavior. I would say that the current issue is blocked.

Regarding alizer's onboarding, I would say maybe we could consider excluding this task from #166 as we have now transformed #159 into an epic. Maybe we can onboard alizer having merged the 2 of the 4 tasks ( ##153 and #225 - both under review)

cc @elsony @mike-hoang

@thepetk thepetk moved this from In Progress to Todo in Alizer Project Jun 12, 2023
@thepetk thepetk added the status/blocked Blocked by another issue label Jun 13, 2023
@thepetk
Copy link
Collaborator Author

thepetk commented Jun 13, 2023

I've put the blocked label for this and updated the blocking issue devfile/api#1128

@thepetk thepetk moved this from Todo to Backlog in Alizer Project Jun 13, 2023
@thepetk thepetk removed their assignment Jun 13, 2023
@thepetk thepetk removed the status/blocked Blocked by another issue label Jun 20, 2023
@thepetk
Copy link
Collaborator Author

thepetk commented Jun 20, 2023

Removed blocked from the issue as devfile/api#1128 is closed

@thepetk thepetk self-assigned this Jun 27, 2023
@thepetk thepetk moved this from Backlog to Todo in Alizer Project Jun 27, 2023
@thepetk thepetk moved this from Todo to In Progress in Alizer Project Jun 29, 2023
@thepetk thepetk moved this from In Progress to Review in Progress in Alizer Project Jun 29, 2023
@thepetk
Copy link
Collaborator Author

thepetk commented Jun 29, 2023

I've updated the #234 and is now under review :)

@thepetk
Copy link
Collaborator Author

thepetk commented Jun 30, 2023

closing in favor of devfile/api#1171

@thepetk thepetk closed this as completed Jun 30, 2023
@github-project-automation github-project-automation bot moved this from Review in Progress to Done in Alizer Project Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli CLI related issues
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant