This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Add min max cli args #234
Closed
Add min max cli args #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
thepetk
force-pushed
the
feature/add_min_max_cli_args
branch
from
8e8fd0f to
ad67ce8
Compare
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: thepetk <thepetk@gmail.com>
| return nil, err | ||
| } | ||
| // This value is set by the user in order to configure the registry | ||
| resp, err := http.Get(url) //nolint |
Check failure
Code scanning / gosec
Potential HTTP request made with variable url
|
closing in favor of devfile/alizer#5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As part of #159 we are introducing the two first cli args in order to support specific versions of devfiles. Those two are
min-versionandmax-version.If this argument is passed in the cli we are updating the URL for the download of the devfiles from the registry (following this link). This way we are filtering the list of devfiles we are getting from the registry.
Some edge cases:
min-versionis higher thanmax-versionanerroris raised.min-versionand/ormax-versionis lower than2.0.0(the lowest accepted version from the registry API) then an error is raised.A slight addition is also made to the
model.DevfileTypein order to include information for versions. For backwards compatibility reasons we are no longer usingSelectDevFilesFromRegistrybutMatchDevfiles.A new
model.DevfileFilteris created in order to include all future filters inside the devfile API and ensure scalability.Updates are made inside the documentation of the project to include all changes introduced and test cases regarding the URL update are added.
Which issue(s) does this PR fix
fixes #226
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
Documentation
How to test changes / Special notes to the reviewer