This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
fix: prevent skipping current folder if only a single file needs to be ignored (#99) #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #99
The problem was that if a single file matched a rule in gitignore, the whole folder was skipped. So if the file was in the root, no component were detected as only the files discovered until that moment would be used.
E.g I have this treeview
The gitignore is like
When Alizer walks on the
.classpath
file, it matches the rule in gitignore and all folder is skipped.Code in path lib which caused the misbehaviour
With this patch it skips items in the right way. Returns nil if it's a file or skipDir if it's a directory.