This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
Add second tag for spring framework #169
Merged
thepetk
merged 8 commits into
redhat-developer:main
from
thepetk:update_tags_for_spring
Apr 11, 2023
Merged
Add second tag for spring framework #169
thepetk
merged 8 commits into
redhat-developer:main
from
thepetk:update_tags_for_spring
Apr 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thepetk <thepetk@gmail.com>
yangcao77
suggested changes
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a unit test for this change?
Signed-off-by: thepetk <thepetk@gmail.com>
@yangcao77 I've updated the mocked values of getDevFileTypes in order to provide |
yangcao77
reviewed
Apr 3, 2023
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
yangcao77
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change. Look good to me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a second item inside the
SpringDetector.GetSupportedFrameworks
func. As a result, when the Spring Boot framework is identified inside a project, it adds two tags inside thelanguage.Frameworks
Finally, it will be able to match the given tag of "Spring Boot" whenever it is updated from the registry side. Note, that this solution is backwards compatible. Once the update of the "Spring" tag to "Spring Boot" is done, we can iterate and have only "Spring Boot" as supported network.
Which issue(s) this PR fixes:
fixes #136
Test outputs
I've forced updated locally the tag "Spring" to "Spring Boot" and tested this solution:
And the output is: