This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Add udi image case for mocked values of devfile types #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Inside this PR we are introducing the universal image. The current PR is ensuring that we are always checking in our tests that there is no impact of this change (e.g. the universal image devfile is selected first instead of a more related one).
To do this PR adds a new mocked
model.devfileTypeinstance insidetests.getDevFileTypes():{ Name: "udi", Language: "Polyglot", ProjectType: "default", Tags: []string{ "Java", "Maven", "Scala", "PHP", ".NET", "Node.js", "Go", "Python", "Pip", "ubi8", }, },Which issue(s) this PR fixes:
fixes #174