This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Fix express.js port recognition #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
thepetk
force-pushed
the
fix_node_port_recognition
branch
from
6198aab to
580dbf2
Compare
mike-hoang
approved these changes
Apr 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the port recognition logic for
express_detector. Moreover, it adds an additional check for cases that we use a variable which takes its value after the usage of the logical OR operator (e.g.var PORT = process.env.PORT || 8080). The new logic for thefunc getPortof the detector will be:Note that all other detectors (
angular,next,nodejs,nuxt,reactjs,svetle, andvue) are not using the same logic in order to perform port recognition, that's why this workaround is not global for nodejs detectors.Which issue(s) this PR fixes:
This PR is part of the solution and fixes #146