This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Fix vertx devfile matching #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
mike-hoang
approved these changes
May 2, 2023
Signed-off-by: thepetk <thepetk@gmail.com>
|
@mike-hoang I had to rebase the current branch after the merge for #193 :) so I've reset your review |
mike-hoang
approved these changes
May 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It is similar to #193 and it introduces the
matchesFormattedfunction. Upon checking thelanguage.Frameworks&devFile.ProjectTypeif they are equals, it removes the special characters and the spaces in order to make a better comparison.It adds the
TestDetectVertxDevfilein order to ensure that thevert.xdevfile will be selected for projects with main component of Vert.x framework.Which issue(s) this PR fixes:
Fixes #189