This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
Handle errors from regexp #200
Merged
thepetk
merged 7 commits into
redhat-developer:main
from
thepetk:handle_runtime_regexp_errors
May 4, 2023
Merged
Handle errors from regexp #200
thepetk
merged 7 commits into
redhat-developer:main
from
thepetk:handle_runtime_regexp_errors
May 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thepetk <thepetk@gmail.com>
…ch errors Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
yangcao77
reviewed
May 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed that the issue has been fixed with this change.
can we add any test cases for this issue?
I want to add the same project which we have faced the issue. |
@yangcao77 I've added an extra test case in So this way we can merge the current workaround which will unblock HAS and this specific test case will be added with the next merge. |
Merged
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces the
regexp.MustCompile
withregexp.Compile
in case we provide avar
and not a fixed/hardcoded value. This way it ensures that we will be able to catch any errors from regexp.Example Replace:
With:
Which issue(s) this PR fixes:
Fixes #199