This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
updating github action workflows #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Hoang <mhoang@redhat.com>
Signed-off-by: Michael Hoang <mhoang@redhat.com>
Signed-off-by: Michael Hoang <mhoang@redhat.com>
Signed-off-by: Michael Hoang <mhoang@redhat.com>
thepetk
approved these changes
May 19, 2023
There was a problem hiding this comment.
I see that the gosec check returns a warning Warning: Code scanning cannot determine the alerts introduced by this pull request, because 1 configuration present on refs/heads/main was not found.
I've looked into it and I found this answer so I think is ok.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The intent of this PR is to fix all GA deprecation warnings. This is done by:
actions/checkoutandactions/setup-gofrom v2 to v3/resourcesdirectory and in turn removing thecheckLang.ymlworkflow (which contains an action that has a warning)The
checkLang.ymlworkflow was used to check that the language yamls in/resourcesmatched the language yamls in the go app. Now that go is the only implementation, there is no need for theresourcesdirectory.related to #177
Which issue(s) does this PR fix
fixes #213