Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

adding utils unit tests #223

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Conversation

mike-hoang
Copy link
Contributor

@mike-hoang mike-hoang commented May 25, 2023

What does this PR do?

adds unit tests for pkg/utils

Which issue(s) does this PR fix

fixes #206

PR acceptance criteria

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Unit/Functional tests

  • Documentation

How to test changes / Special notes to the reviewer

@mike-hoang mike-hoang force-pushed the 206 branch 3 times, most recently from 307bbfd to d8e8b3c Compare May 31, 2023 22:07
@mike-hoang mike-hoang requested a review from thepetk May 31, 2023 22:07
@mike-hoang mike-hoang marked this pull request as ready for review May 31, 2023 22:08
@mike-hoang mike-hoang self-assigned this May 31, 2023
Copy link
Collaborator

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say we might need a test for cache.go -> GetCachedFilePathsFromRoot
And also for the language_file_handler.go

go/pkg/utils/detector_test.go Show resolved Hide resolved
Signed-off-by: Michael Hoang <mhoang@redhat.com>
Copy link
Collaborator

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 1, 2023
@mike-hoang mike-hoang merged commit 6947f49 into redhat-developer:main Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create utils unit tests
2 participants