This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Enhance logging #233
Merged
Enhance logging #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mike-hoang
reviewed
Jun 12, 2023
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
mike-hoang
approved these changes
Jun 13, 2023
Signed-off-by: thepetk <thepetk@gmail.com>
mike-hoang
approved these changes
Jun 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates the
--logCLI argument for all command and adds logging to all three commands (devfile,componentandanalyze). This argument accepts only three values (warning, debug, info). In case of absence thezapcore.ErrorLevelis selected and in case of wrong level an error is raised.The V-levels have been used in order to separate debug level logs from info etc.
Additionally, it introduces the
utils.loggerfunctionality. Inside this file we are declaring a global variable calledCliLoggerwhich initially is not initialized. Each time that we want to use the logger inside alizer we have toutils.GetOrCreateLogger, in order to be able to use the same level of logging all the time.Every time that we want to generate a new logger, we check the given
logging leveland we are creating a newzaplogger (logr.Logger).Which issue(s) does this PR fix
fixes #153
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
Documentation
How to test changes / Special notes to the reviewer