-
Notifications
You must be signed in to change notification settings - Fork 17
Add binaries to every new release #237
Add binaries to every new release #237
Conversation
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Overall, the workflow works and looks ok but I'm wondering if this is the right approach? Compared to odo, they push all their images to a mirror after signing and verifying: https://developers.redhat.com/content-gateway/rest/mirror/pub/openshift-v4/clients/odo/ Currently the binary for macOS isn't signed so we get the "cannot be verified error" which is a little annoying to have to go into settings every time to disable
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the binary for macOS isn't signed so we get the "cannot be verified error" which is a little annoying to have to go into settings every time to disable
- By using the github action, do we still have the issue mentioned earlier?
- The binary gets created for each new release as part of this PR. However, where do we expose those release builds for download? Are we adding something to the readme so that the user knows that they can download those binaries?
By using the github actions I'm not sure if we will be able to sign the binaries.
The binary is added to each release tag. So they can be downloaded if someone accesses the release page. I could create a section in readme with instructions on how to download the binary |
Signed-off-by: thepetk <thepetk@gmail.com>
@elsony and @mike-hoang I've added a small section in readme with instructions on how someone can download the binaries. As mentioned above, for the signing I don't think there is a way to achieve this through public github-actions |
What does this PR do?
Introduces the
release.yaml
workflow which will add 5 binaries into an existing release. Those will be:The flow of a release would require a user to push a tag in order to trigger this workflow. As a result those 5 binaries will be added to the tag.
Our release process remains the same:
release.yaml
Which issue(s) does this PR fix
fixes #40
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
Documentation
How to test changes / Special notes to the reviewer
A test run for this flow has already tested here: https://github.com/thepetk/alizer/releases/tag/v1.0.0