Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

chore: reorganize repo - add java folder #26

Merged
merged 4 commits into from
Jul 2, 2021
Merged

chore: reorganize repo - add java folder #26

merged 4 commits into from
Jul 2, 2021

Conversation

lstocchi
Copy link
Collaborator

@lstocchi lstocchi commented Jul 1, 2021

No description provided.

@lstocchi
chore: reorganize repo - add java folder
31ecbb2 
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
@lstocchi lstocchi requested a review from jeffmaury July 1, 2021 15:22
jeffmaury
jeffmaury suggested changes Jul 1, 2021
View reviewed changes
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also but may be delayed it may be good that test projects can be shared between language specific implementations

README.md Outdated Show resolved Hide resolved
java/.gitignore Outdated Show resolved Hide resolved
lstocchi added 2 commits July 1, 2021 18:29
@lstocchi
fix ci builds and fix based on review
12c30a6 
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
@lstocchi
fix workflow location file
57b09f3 
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
@lstocchi lstocchi requested a review from jeffmaury July 1, 2021 16:42
jeffmaury
jeffmaury approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jeffmaury
jeffmaury suggested changes Jul 2, 2021
View reviewed changes
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Jenkinsfile must be adapted

@lstocchi
fix Jenkinsfile and release workflow
a4c0db9 
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
@lstocchi lstocchi requested a review from jeffmaury July 2, 2021 07:46
jeffmaury
jeffmaury approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lstocchi lstocchi merged commit 7678de7 into redhat-developer:main Jul 2, 2021
@lstocchi lstocchi deleted the reorganization branch July 2, 2021 07:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffmaury jeffmaury jeffmaury approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lstocchi @jeffmaury