Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

chore: add Jenkinsfile for Javascript implementation #29

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

jeffmaury
Copy link
Member

Fixes #28

Signed-off-by: Jeff MAURY jmaury@redhat.com

Fixes redhat-developer#28

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
@jeffmaury jeffmaury requested a review from lstocchi July 2, 2021 14:52
Copy link
Collaborator

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I guess we need to change the name inside package.json? Do we call this alizer as well? Right now it is

"name": "language-recognizer",

@jeffmaury
Copy link
Member Author

LGTM

I guess we need to change the name inside package.json? Do we call this alizer as well? Right now it is

"name": "language-recognizer",

@redhat-developer/alizer

I think readme needs to be updated as well

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
@jeffmaury jeffmaury requested a review from lstocchi July 2, 2021 16:14
@jeffmaury jeffmaury merged commit bb19654 into redhat-developer:main Jul 2, 2021
@jeffmaury jeffmaury deleted the GH-28 branch July 2, 2021 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Jenkinsfile for Javascript/Typescript implementation
2 participants