-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it but it looks like the glob-ignore library doesn't work as expected. If i add a rule (to ignore .java files) inside the .gitignore in the quarkus project used for tests, it still fetches all .java files. Am i missing something?
Hm, that strange, let me check |
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@lstocchi It turndown that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a partial implementation of .gitignore as it does only handle the root .gitignore
Maybe worth having .gitignore parsing and loading in a separate function
Unit test are welcomed
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
This PR enhance
alizer
npm package:glob-gitignore
instead ofglob
to list target files, by default it will ignore file/folder listed in.gitignore
filebuild
npm script (clean
+compile
)*.ts
files