This repository has been archived by the owner on Nov 10, 2021. It is now read-only.
[#DEVELOPER-3029] Start all additional services with docker-compose up #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t helps with Docker ports
|
@LightGuard - this will hopefully fix @rctrh 's PR #1097 . @rctrh once this has been merged into master you will need to rebase to get this change into your PR. |
|
retest this please |
1 similar comment
|
retest this please |
|
@LightGuard Are you able to review and merge this? Starting all services at once using docker-compose seems to resolve the issues with ports being in use. It seems to occur when using docker-compose run and starting up multiple supporting services. |
|
@LightGuard - could you please review this ASAP? @rctrh needs it for #1097 to run. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverted to starting all services with a docker-compose up to see if we can resolve the ports in use issue.