Add vscode GitHub Pull Requests plugin

[vinokurig]

What does this PR do?

Add vscode GitHub Pull Requests plugin to the plugins list page.

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-1226

Release Notes

Docs PR (if applicable)

[nickboldt]

-1, changes requested inline

[nickboldt]

Assuming that this new plugin will need to be documented as it'll improve git-related workflows in Che/CRW, please also link to

Docs PR (if applicable)

or open a related RHDEVDOCS issue to track the work separately.

[ericwill]

Building this extension on the jenkins pipeline fails (of course). This PR may have to wait until I get the Dockerfile based build system up and running (hopefully before Christmas).

[MichalMaler]

@ericwill Hello Eric! Let me know when I can put this back in CRW docs. I think it will be in January, right? Cheers

[ericwill]

@ericwill Hello Eric! Let me know when I can put this back in CRW docs. I think it will be in January, right? Cheers

Yes, early January sounds good.

[nickboldt]

@vinokurig can you apply requested changes to this PR so we can merge it into 2.6?

[ericwill]

We still need to build the GitHub PR plugin ourselves, in https://github.com/redhat-developer/codeready-workspaces-vscode-extensions

I started this work but it's still pending.

[vinokurig]

I managed to build the plugin in my fork: https://github.com/vinokurig/codeready-workspaces-vscode-extensions/releases/tag/v7076c43 by updating the plugin version to 0.21.4. The build of the current 0.20.0 version fails, probably the author did some patches to publish it. The problem is that the 0.21.4 version doesn't work in che-theia due to missing API. I've filed an issue to update the plugin in Che: eclipse-che/che#18661

[ericwill]

I managed to build the plugin in my fork: https://github.com/vinokurig/codeready-workspaces-vscode-extensions/releases/tag/v7076c43 by updating the plugin version to 0.21.4. The build of the current 0.20.0 version fails, probably the author did some patches to publish it. The problem is that the 0.21.4 version doesn't work in che-theia due to missing API. I've filed an issue to update the plugin in Che: eclipse/che#18661

Florent was able to build the extension, here is the link: https://github.com/redhat-developer/codeready-workspaces-vscode-extensions/releases/download/vdb8b64f/vscode-pull-request-github-0.20.0.vsix

Let's include 0.20.0 in CRW 2.6 and we can explore updating to 0.21.4 later on.

[nickboldt]

OK, I'm good to merge this once someone fixes the date '2020-10-8' ... not only is the day only a single digit, it's 3 months ago. Please bump that to a date in Jan 2021 for accuracy.

[MichalMaler]

Great stuff and nice progress! Let me know when I can return the docs about this plugin back to CRW. BTW, do we need to update the Che-relative content?

https://www.eclipse.org/che/docs/che-7/end-user-guide/version-control/#accessing-a-git-repository-via-ssh_version-control

[ericwill]

Great stuff and nice progress! Let me know when I can return the docs about this plugin back to CRW. BTW, do we need to update the Che-relative content?

https://www.eclipse.org/che/docs/che-7/end-user-guide/version-control/#accessing-a-git-repository-via-ssh_version-control

When this PR is merged then you can restore the docs. As for the content, I'll have Igor verify the content with you when he gets back from PTO next week.

[MichalMaler]

Ok, great. Thx Eric

[ericwill]

OK, I'm good to merge this once someone fixes the date '2020-10-8' ... not only is the day only a single digit, it's 3 months ago. Please bump that to a date in Jan 2021 for accuracy.

I've pushed a new version to fix the date and the vsix reference, I think we can merge this one now

[vinokurig]

I've opened a doc's PR that enables the GitHub documentation for CRW: eclipse-che/che-docs#1784

[vinokurig]

@nickboldt Could you please review it again?