Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Fedora 37 & add Fedora 39 #323

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Remove Fedora 37 & add Fedora 39 #323

merged 3 commits into from
Jan 24, 2024

Conversation

nicrowe00
Copy link
Contributor

Removing Fedora 37 from the CI as it's now EOL and adding Fedora 39.

@nicrowe00 nicrowe00 requested a review from tmds December 14, 2023 10:39
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@omajid
Copy link
Member

omajid commented Dec 14, 2023

Oh. The CI config is trying to use dnf on alpine.

I think we can drop these lines now:

          if [[ ${{ matrix.dotnet_version }} == "8.0" ]]; then
            dnf install -y dnf-plugins-core
            if [[ ${{ matrix.container_image }} == *ubi8* ]] ; then
              dnf copr enable -y @dotnet-sig/dotnet-preview rhel-8-$(uname -m)
            else
              dnf copr enable -y @dotnet-sig/dotnet-preview
            fi
          fi

That was trying to use the https://copr.fedorainfracloud.org/coprs/g/dotnet-sig/dotnet-preview/ repo to install .NET 8, but .NET 8 should be available everywhere now.

Removing Fedora 37 from the CI as it's now EOL and adding Fedora 39.
@omajid
Copy link
Member

omajid commented Dec 14, 2023

@ayakael hey, do you know how we can install .NET 8 on alpine:edge? Based on https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/49831/diffs#c3a9fd6134014af4ee84828b0a9166e7f40f9d85, I was expecting the following to work, but it doesn't:

$ podman run -it alpine:edge
Resolved "alpine" as an alias (/etc/containers/registries.conf.d/000-shortnames.conf)
Trying to pull docker.io/library/alpine:edge...
Getting image source signatures
Copying blob b790c763077d done   | 
Copying config 23d4cb6bde done   | 
Writing manifest to image destination
...
/ # cat /etc/apk/repositories 
https://dl-cdn.alpinelinux.org/alpine/edge/main
https://dl-cdn.alpinelinux.org/alpine/edge/community
https://dl-cdn.alpinelinux.org/alpine/edge/testing
/ # apk update
fetch https://dl-cdn.alpinelinux.org/alpine/edge/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/edge/community/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/edge/testing/x86_64/APKINDEX.tar.gz
v3.19.0-466-gc81aaeb1200 [https://dl-cdn.alpinelinux.org/alpine/edge/main]
v3.19.0-466-gc81aaeb1200 [https://dl-cdn.alpinelinux.org/alpine/edge/community]
v3.19.0-466-gc81aaeb1200 [https://dl-cdn.alpinelinux.org/alpine/edge/testing]
OK: 29721 distinct packages available
/ # apk add dotnet-sdk-8.0 dotnet-doc
ERROR: unable to select packages:
  dotnet-sdk-8.0 (no such package):
    required by: world[dotnet-sdk-8.0]

@omajid
Copy link
Member

omajid commented Jan 24, 2024

All errors are in tools-in-path and managed-symbols-are-available, both of which are known issues. I am merging this PR.

@omajid omajid merged commit 18fb8e7 into redhat-developer:main Jan 24, 2024
19 of 24 checks passed
@ayakael
Copy link
Contributor

ayakael commented Jan 24, 2024

@omajid Sorry for not having come back to you, december was a busy month. .NET 8 is now merged on edge. I've re-enabled CI via #330

@omajid
Copy link
Member

omajid commented Jan 24, 2024

No worries, and thanks for that PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants