Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend distribution-packages to cover -dbg packages too #334

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

omajid
Copy link
Member

@omajid omajid commented Jan 29, 2024

No description provided.

@omajid
Copy link
Member Author

omajid commented Jan 29, 2024

There's a chicken and egg problem with getting tests to pass. I would like the tests to get enabled so I can use them when doing package builds and make sure my packaging changes are completely. On the other hand, until the packaging changes are complete, the newly-introduced tests will keep on failing.

I would like to merge this, and then fix the packages over the next few weeks. Unfortunately, that means the tests will stay failing in CI for the next few weeks.

Anyone have objections to this?

@nicrowe00
Copy link
Contributor

I would prefer that the test was properly tested and passing before introducing it to CI but if it's necessary for completing the package builds then I have no issue with merging it.

cc @tmds

@tmds
Copy link
Member

tmds commented Jan 30, 2024

We should aim to minimize the time this test is causing failures.

Note: this won't affect the hydra CI jobs, where this test gets skipped. It will affect jobs like the ones for which we've just merged #333.

@omajid
Copy link
Member Author

omajid commented Jan 30, 2024

I would prefer that the test was properly tested and passing before introducing it to CI but if it's necessary for completing the package builds then I have no issue with merging it.

I tested this locally and it passes with fixed-up packages. Test pipeline in this PR shows that it correctly flags issues in packages that are missing -dbg subpackage. Is that good enough testing to make sure this test works correctly? If we find any issues in this test, I am going to fix them.

This PR is not a strict requirement to make the packaging changes, but it makes sure the changes are complete and working. Without this test running, if I screw up a package change, then merge this test, fixing it will take even longer, and might miss the February update window.

We should aim to minimize the time this test is causing failures.

My goal is to have this passing by mid-Feb everywhere.

@omajid omajid merged commit 113ef65 into redhat-developer:main Jan 30, 2024
17 of 25 checks passed
@tmds tmds mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants