Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing .NET 7 from tests, removing outdated tests and increasing timeout-minutes #350

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Removing .NET 7 from tests, removing outdated tests and increasing timeout-minutes #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- uses: actions/checkout@v4

- name: Install .NET ${{ matrix.dotnet_version }}
timeout-minutes: 5
timeout-minutes: 10
run: |
set -euo pipefail
cat /etc/os-release
Expand All @@ -65,7 +65,7 @@ jobs:
fi

- name: Install Test dependencies
timeout-minutes: 2
timeout-minutes: 5
run: |
if grep fedora /etc/os-release ; then
dnf install -y python3 wget $(grep '^Dependencies(dnf): ' README.md | cut -d: -f2-) --skip-broken
Expand Down
11 changes: 0 additions & 11 deletions aspnetpatch-21/test.json
View file
Open in desktop

This file was deleted.

141 changes: 0 additions & 141 deletions aspnetpatch-21/test.sh
View file
Open in desktop

This file was deleted.

20 changes: 9 additions & 11 deletions debugging-via-dotnet-dump/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,17 +319,15 @@ grep 'Attributes: *PEFile' dump.out
grep 'MetaData start address: *0' dump.out


# FIXME: dumpmt seems to work on 7.0.1 but not 7.0.0?
# heading "dumpmt"
# dump-analyze 'name2ee *!System.String' > dump.out
# cat dump.out
# grep 'MethodTable:' dump.out | awk '{print $2}'
# string_method_table=$(grep 'MethodTable:' dump.out | awk '{print $2}')
# dump-analyze "dumpmt ${string_method_table}" > dump.out
# cat dump.out
# grep -E '^Name:[ \n\t]+System.String' dump.out
# grep -E "^File:[ \n\t]+${framework_dir}" dump.out

heading "dumpmt"
dump-analyze 'name2ee *!System.String' > dump.out
cat dump.out
grep 'MethodTable:' dump.out | awk '{print $2}'
string_method_table=$(grep 'MethodTable:' dump.out | awk '{print $2}')
dump-analyze "dumpmt ${string_method_table}" > dump.out
cat dump.out
grep -E '^Name:[ \n\t]+System.String' dump.out
grep -E "^File:[ \n\t]+${framework_dir}" dump.out

nicrowe00 marked this conversation as resolved.
Show resolved Hide resolved
heading "dumpobj"
dump-analyze 'dumpstackobjects' > dump.out
Expand Down
11 changes: 0 additions & 11 deletions extract-bundle-dir/test.json
View file
Open in desktop

This file was deleted.

45 changes: 0 additions & 45 deletions extract-bundle-dir/test.sh
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion host-probes-rid-assets/test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
"cleanup": true,
"skipWhen": [
"os=alpine,version=6", // see https://github.com/redhat-developer/dotnet-regular-tests/pull/303#issuecomment-1755727884
"os=alpine,version=7",
],
"ignoredRIDs":[
]
Expand Down
1 change: 0 additions & 1 deletion managed-symbols-available/test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
"cleanup": true,
"skipWhen": [
"vmr-ci,version=6", // unpacking symbols is a hassle
"vmr-ci,version=7",
"non-packaged",
],
"ignoredRIDs":[
Expand Down
2 changes: 0 additions & 2 deletions restore-with-rid/test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
"cleanup": true,
"skipWhen":[
"version=6,arch=s390x", // no runtime pack available
"version=7,arch=s390x",
"version=7,arch=ppc64le"
],
"ignoredRIDs":[
]
Expand Down
2 changes: 0 additions & 2 deletions sha1-validation/test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
"type": "bash",
"cleanup": true,
"skipWhen": [
"os=rhel.9,version=7", // Test fails on RHEL9 with .NET 7: https://issues.redhat.com/browse/RHEL-25254
"os=centos.9,version=7", // Test fails on RHEL9 with .NET 7: https://issues.redhat.com/browse/RHEL-25254
],
"ignoredRIDs":[
]
Expand Down
Loading