Make liblttng-ust_sys-sdt.h pass when lttng is not installed #361
Conversation
The lttng-ust dependency is technically optional. If .NET is installed and that dependency isn't, assume .NET is okay.
|
@nicrowe00 What do you think? lttng-ust is an optional dependency. Should we force it to be installed for the sake of this test? |
|
@omajid I'm inclined to say yes, we should force-install it for the test, just to verify that everything is as expected with the dependency. I don't mind though if we decide not to force-install it as it is optional like you mentioned. It depends on how worried we are about optional dependencies. |
|
The goal of the test is to verify that lttng is working, we shouldn't make it @omajid I don't know what triggered the PR. If there is an environment where lttng is not present, you can describe it using a trait (like |
It isn't. The test is trying to verify that lttng-ust has support for systemtap. Which, now that I think about it, is not something relevant for .NET at all. .NET doesn't care if lttng-ust has some specific feature or not, as long as it works for tracing. And this test doesn't verify whether lttng-ust can trace correctly. So whether this feature is present or not doesn't make a difference to .NET I am tempted to just delete this test. If anything, this should be a test in lttng-ust, not .NET. |
Sounds good to me. |
This test doesn't test that .NET is compatible with lttng-ust. It doesn't test that lttng-ust works for tracing .NET. This test only looks for features in lttng-ust (specifically, systemtap support). These features that are not really relevant to .NET. If anything, this should be a test in the lttng-ust package itself. To ease maintenance, lets just delete this.
The lttng-ust dependency is technically optional. If .NET is installed and that dependency isn't, assume .NET is okay.