Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for source-built NativeAOT. #362

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Conversation

tmds
Copy link
Member

@tmds tmds commented Aug 19, 2024

No description provided.

@tmds tmds requested review from omajid and nicrowe00 August 19, 2024 08:34
@tmds
Copy link
Member Author

tmds commented Aug 19, 2024

The test added here is failing on the fedora:40 image with .NET 9 preview 7 due to missing dependencies when linking:

  console -> /__w/dotnet-regular-tests/dotnet-regular-tests/nativeaot-sb/bin/Release/net9.0/fedora.40-x64/console.dll
  Generating native code
  /usr/bin/ld.bfd: cannot find -lssl: No such file or directory
  /usr/bin/ld.bfd: cannot find -lcrypto: No such file or directory

To avoid the user having to figure out what packages to install, we can require these packages from our dotnet-sdk-aot package. @omajid wdyt?

@omajid
Copy link
Member

omajid commented Aug 19, 2024

To avoid the user having to figure out what packages to install, we can require these packages from our dotnet-sdk-aot package. @omajid wdyt?

I couldn't agree more. I already implemented this, but didn't test it fully. so I must have missed some stuff: https://gitlab.com/redhat/centos-stream/rpms/dotnet9.0/-/blob/c10s/dotnet9.0.spec?ref_type=heads#L413-414

@tmds
Copy link
Member Author

tmds commented Aug 19, 2024

I couldn't agree more. I already implemented this, but didn't test it fully. so I must have missed some stuff: https://gitlab.com/redhat/centos-stream/rpms/dotnet9.0/-/blob/c10s/dotnet9.0.spec?ref_type=heads#L413-414

You can use this test to check.

@omajid, do you have feedback about the PR, or is it good to merge?

@tmds tmds merged commit f93664f into redhat-developer:main Aug 20, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants